Added TypesScript support #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
======================================
Coverage 88.5% 88.5%
======================================
Files 9 9
Lines 600 600
Branches 158 158
======================================
Hits 531 531
Misses 58 58
Partials 11 11Continue to review full report at Codecov.
|
yesmeck
reviewed
May 2, 2018
types/rc-calendar/index.d.ts
Outdated
| export interface Props { | ||
| prefixCls?: string; | ||
| className?: string; | ||
| style?: object; |
yesmeck
reviewed
May 2, 2018
types/rc-calendar/index.d.ts
Outdated
| style?: object; | ||
| defaultValue?: Moment; | ||
| value?: Moment; | ||
| selectedValue?: object; |
yesmeck
reviewed
May 2, 2018
types/rc-calendar/index.d.ts
Outdated
| onOk?: () => void; | ||
| onKeyDown?: () => void; | ||
| timePicker?: React.ReactNode; | ||
| dateInputPlaceholder?: any; |
yesmeck
reviewed
May 2, 2018
| import Calendar from 'rc-calendar'; | ||
|
|
||
| const action = (date: moment.Moment) => { | ||
| date.subtract(1); |
yesmeck
reviewed
May 2, 2018
types/rc-calendar/tsconfig.json
Outdated
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "compilerOptions": { | |||
yesmeck
reviewed
May 2, 2018
types/rc-calendar/index.d.ts
Outdated
| @@ -0,0 +1,38 @@ | |||
| // Type definitions for rc-calendar 9.6 | |||
There was a problem hiding this comment.
I'd like to put this file under the root of the project.
There was a problem hiding this comment.
@yesmeck Thank you review 👍
renamed: types/rc-calendar/index.d.ts -> index.d.ts
renamed: types/rc-calendar/rc-calendar-tests.tsx -> rc-calendar-tests.tsx
renamed: types/rc-calendar/tsconfig.json -> tsconfig.json
renamed: types/rc-calendar/tslint.json -> tslint.jsonDo I need to move the file as follows?
If that's okay add the path to package.json files
There was a problem hiding this comment.
Yes, please just put these files under the root of the project.
|
Need to add the |
|
Fixed 👍 |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #380