fix: svg-sprite-loader exception for "npm start" and bootstrap example #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gException: svg-sprite-loader exception. svg-sprite-loader in extract mode requires the corresponding plugin fixes #99 not only the published example was broken, I got the same error for development mode (npm start). This patch fixes that aswell
…te Bootstrap theming (and to test if example correctly includes Bootstrap CSS, see 811089c
|
Could you consider to merge this PR? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update bootstrap version to fix the error
Module build failed: ExtractPluginMissingException: svg-sprite-loader exception. svg-sprite-loader in extract mode requires the corresponding plugin.Fixes #99, and I also got the same error when running development preview via
npm start. That is also fixes by this PR.I also added Bootstrap-styled components (buttons) to illustrate the Bootstrap theming (and to test if example now correctly includes Bootstrap CSS)