-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support of ctrl and shift key & simple formatter #47
Conversation
f1fadda
to
e2b8141
Compare
I will check this later in this week, could you add some test cases? |
Add some test cases for the bug fixed and the formatter, and also the combination keys Thanks, |
examples/simple.js
Outdated
value={this.state.value} | ||
style={{ width: 100 }} | ||
readOnly={this.state.readOnly} | ||
onChange={this.onChange} | ||
disabled={this.state.disabled} | ||
autoFocus={false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to create another demo than modify this one.
src/index.js
Outdated
ratio = 0.1; | ||
} else if (e.shiftKey) { | ||
ratio = 10; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put those ratio code to a this.getRatio(e)
function.
Could you add some API document and instructions. |
tests/index.js
Outdated
ref="inputNum" | ||
step={1} | ||
value={5} | ||
formatter={(num) => {return `$ ${num}`;}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- formatter={(num) => {return `$ ${num}`;}}
+ formatter={num => `$ ${num}`}
<td>Function</td> | ||
<td></td> | ||
<td>Specifies the format of the value presented</td> | ||
</tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also document short keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi~ I'll check on that~ Sorry for my late reply~ |
712d269
to
a7aed81
Compare
modify README(short keys) [bug fix] counting remain fix test on useTouch
2889b5c
to
b1c5f96
Compare
1、support of ctrl and shift key which could +10, +0.1 times of step
2、simple formatter, with the function eg:
3、bug fix, the value still changes when pressing up or down key even with the readonly status
Thanks, Sincerely
Jiramew