support of ctrl and shift key & simple formatter #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiramew
force-pushed
the
feature/shift_ctrl
branch
from
f1fadda
to
e2b8141
Compare
|
I will check this later in this week, could you add some test cases? |
|
Add some test cases for the bug fixed and the formatter, and also the combination keys Thanks, |
afc163
reviewed
Mar 1, 2017
examples/simple.js
Outdated
| value={this.state.value} | ||
| style={{ width: 100 }} | ||
| readOnly={this.state.readOnly} | ||
| onChange={this.onChange} | ||
| disabled={this.state.disabled} | ||
| autoFocus={false} |
There was a problem hiding this comment.
It is better to create another demo than modify this one.
afc163
reviewed
Mar 1, 2017
src/index.js
Outdated
| ratio = 0.1; | ||
| } else if (e.shiftKey) { | ||
| ratio = 10; | ||
| } |
There was a problem hiding this comment.
You can put those ratio code to a this.getRatio(e) function.
|
Could you add some API document and instructions. |
afc163
reviewed
Mar 1, 2017
tests/index.js
Outdated
| ref="inputNum" | ||
| step={1} | ||
| value={5} | ||
| formatter={(num) => {return `$ ${num}`;}} |
There was a problem hiding this comment.
- formatter={(num) => {return `$ ${num}`;}}
+ formatter={num => `$ ${num}`}
afc163
reviewed
Mar 1, 2017
| <td>Function</td> | ||
| <td></td> | ||
| <td>Specifies the format of the value presented</td> | ||
| </tr> |
There was a problem hiding this comment.
|
There is a tiny problem.
|
|
Hi~ I'll check on that~ Sorry for my late reply~ |
Jiramew
force-pushed
the
feature/shift_ctrl
branch
from
712d269
to
a7aed81
Compare
modify README(short keys) [bug fix] counting remain fix test on useTouch
Jiramew
force-pushed
the
feature/shift_ctrl
branch
from
2889b5c
to
b1c5f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、support of ctrl and shift key which could +10, +0.1 times of step
2、simple formatter, with the function eg:
3、bug fix, the value still changes when pressing up or down key even with the readonly status
Thanks, Sincerely
Jiramew