fix: Calendar组件选择 “12小时”会无限循环的问题 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endDate = [0, 0, 0] -> Datepicker.tsx#render -> [12, 0, 0] -> Picker.tsx -> didUpdate -> onValueChange -> value = [0, 0, 0] -> Datepicker endDate 无限循环链路
ziluo
reviewed
Jul 23, 2019
| @@ -449,7 +449,7 @@ class DatePicker extends React.Component<IDatePickerProps, any> { | |||
| let dtValue = [hour + '', time.selMinute + '']; | |||
| let nhour = hour; | |||
| if (use12Hours) { | |||
| nhour = hour === 0 ? 12 : (hour > 12 ? hour - 12 : hour); | |||
| nhour = hour > 12 ? hour - 12 : hour; | |||
There was a problem hiding this comment.
唯一的变化就是hour为零时的变化，原来是返回12，现在是直接返回0，这个对用户无感知么？
doxiaodong
changed the title
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endDate = [0, 0, 0] -> Datepicker.tsx#render -> [12, 0, 0] -> Picker.tsx -> didUpdate -> onValueChange -> value = [0, 0, 0] -> Datepicker endDate
无限循环链路