fix: rtl switch issue https://github.com/ant-design/ant-design/issues/40128 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Feb 3, 2023
| right: | ||
| targetElement.parentElement?.clientWidth! - | ||
| targetElement.clientWidth - | ||
| targetElement.offsetLeft, |
There was a problem hiding this comment.
感觉改多了，是不是把 left 换成 insetInlineStart 就够了？
There was a problem hiding this comment.
好像不行，试了下 offsetLeft 偏移量是受 RTL 模式影响的，会导致计算结果不按预期。
There was a problem hiding this comment.
这里的 thumb 滑块使用 translateX 做的偏移，不是用 left/insetInlineStart 实现的
There was a problem hiding this comment.
再跑下ci，之前的 test case 有问题 修复了一下。
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 99.11% 99.15% +0.04%
==========================================
Files 2 2
Lines 113 119 +6
Branches 29 31 +2
==========================================
+ Hits 112 118 +6
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Wxh16144
reviewed
Feb 6, 2023
Comment on lines
+9
to
+29
| <button | ||
| onClick={() => { | ||
| setDirection('rtl'); | ||
| }} | ||
| style={{ | ||
| padding: '0 8px', | ||
| marginRight: 8, | ||
| }} | ||
| > | ||
| rtl | ||
| </button> | ||
| <button | ||
| onClick={() => { | ||
| setDirection('ltr'); | ||
| }} | ||
| style={{ | ||
| padding: '0 8px', | ||
| }} | ||
| > | ||
| ltr | ||
| </button> |
There was a problem hiding this comment.
主要为了显示清楚一点，所以分成了两个 button，demo 上看上去更直观一点，个人感觉。
vagusX
approved these changes
Feb 6, 2023
vagusX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #40128
💡 Background and solution
Causes of the problem
Because of the display of rtl, there is a problem with the displacement of the calculation logic.
Solution
Fixed displacement under rtl mode.
📝 Changelog
☑️ Self-Check before Merge