Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmented not work in RTL mode #40128

Closed
masoud-Tesna opened this issue Jan 10, 2023 · 6 comments · Fixed by react-component/segmented#167
Closed

Segmented not work in RTL mode #40128

masoud-Tesna opened this issue Jan 10, 2023 · 6 comments · Fixed by react-component/segmented#167
Assignees
@RedJue
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. rtl

Comments

@masoud-Tesna
Copy link

Reproduction link

https://codepen.io/Masoud_tesna/pen/PoBppER?editors=0010

Steps to reproduce

Segmented not work in RTL mode.

What is expected?

.

What is actually happening?

change segment item problem (animation)

Environment Info
antd 5.1.4
React 18
System linux
Browser firefox
@github-actions
Copy link
Contributor

You may look for issues:

  1. 51% Modal animations doesn't work as intended #38232

🤖 By issues-similarity-analysis

@MadCcc MadCcc added the 🐛 Bug Ant Design Team had proved that this is a bug. label Jan 10, 2023
@afc163 afc163 added the rtl label Jan 10, 2023
@masoud-Tesna
Copy link
Author

Does anyone have any ideas?

@vagusX vagusX added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Jan 18, 2023
@ant-design ant-design deleted a comment from github-actions bot Jan 18, 2023
@RedJue
Copy link
Member

RedJue commented Feb 1, 2023

I'm trying to fix it.

@zombieJ zombieJ assigned RedJue and unassigned vagusX Feb 1, 2023
@RedJue RedJue mentioned this issue Feb 3, 2023
Merged
20 tasks
vagusX pushed a commit to react-component/segmented that referenced this issue Feb 6, 2023
@RedJue
fix: rtl switch issue ant-design/ant-design#40128 (#167)
56975dc 
fix ant-design/ant-design#40128
@vagusX
Copy link
Member

vagusX commented Feb 6, 2023

Thanks for @RedJue's contribution, @masoud-Tesna you can try update the dependencies to solve this issue, rc-segmented@v2.1.2 was released.

@afc163
Copy link
Member

afc163 commented Feb 6, 2023

ci failed

@masoud-Tesna
Copy link
Author

Thanks to @RedJue and @vagusX for solving this problem...

@github-actions github-actions bot mentioned this issue Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RedJue RedJue

Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. rtl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rtl switch issue https://github.com/ant-design/ant-design/issues/40128 RedJue/segmented
6 participants
@afc163 @vagusX @RedJue @MadCcc @xrkffgg @masoud-Tesna