Lock touch direction to avoid change on scroll #580
+136
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
The
onStart
trigger is moved fromonTouchStart
toonTouchMove
because we need to act on drag direction. The goal being: If the first touch move is in the correct slider direction, triggeronStart
; Otherwise, ignore further dragging.Added
onTouchEnd
for cleanup.As a result, the following user actions will no longer move a slider: