Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add distanceBetweenHandles #675

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

doong-jo
Copy link
Contributor

@doong-jo doong-jo commented Aug 20, 2020

This solves #402

Added the ability to keep the distance between the handles.

Thanks.

@vercel
Copy link

vercel bot commented Nov 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/slider/8jcy9x8ja
✅ Preview: https://slider-git-distance-range.react-component.vercel.app

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.62%. Comparing base (c790ca8) to head (4255433).

❗ Current head 4255433 differs from pull request most recent head 6eb9ef4. Consider uploading reports for the commit 6eb9ef4 to get more accurate results

Files Patch % Lines
src/Range.tsx 27.27% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##            master     #675       +/-   ##
============================================
- Coverage   100.00%   87.62%   -12.38%     
============================================
  Files           13       11        -2     
  Lines          558      719      +161     
  Branches       169      186       +17     
============================================
+ Hits           558      630       +72     
- Misses           0       89       +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837
Copy link
Member

yoyo837 commented Apr 15, 2023

Rebase please.

Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 6:28am

@doong-jo
Copy link
Contributor Author

@afc163 Would you reivew this PR?

@yoyo837
Copy link
Member

yoyo837 commented Feb 24, 2024

Just add an example?

@doong-jo
Copy link
Contributor Author

Oh, it's changed too much from when I first wrote it. I'll change it to draft state and work on it later.

@doong-jo doong-jo marked this pull request as draft February 24, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants