Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom ref for Table #666

Closed
wants to merge 1 commit into from
Closed

feat: support custom ref for Table #666

wants to merge 1 commit into from

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Sep 13, 2021

@vercel
Copy link

vercel bot commented Sep 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/table/J2NwviEHjvHFJ9xvNwsPZRTHNHqd
✅ Preview: https://table-git-fork-jounqin-feat-tableref-react-component.vercel.app

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #666 (3d87702) into master (730d4df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3d87702 differs from pull request most recent head e5151e7. Consider uploading reports for the commit e5151e7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          28       28           
  Lines         876      879    +3     
  Branches      260      261    +1     
=======================================
+ Hits          873      876    +3     
  Misses          3        3           
Impacted Files Coverage Δ
src/Table.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63bc29...e5151e7. Read the comment docs.

@JounQin
Copy link
Contributor Author

JounQin commented Sep 13, 2021

@afc163 Can we merge and release?

@JounQin
Copy link
Contributor Author

JounQin commented Sep 17, 2021

@afc163 @zombieJ So what about this PR? Should I just close?

@afc163
Copy link
Member

afc163 commented Oct 13, 2021

@afc163 afc163 closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants