Corrects the element that aria- props are applied to #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
=======================================
Coverage 99.40% 99.40%
=======================================
Files 36 36
Lines 1004 1005 +1
Branches 304 304
=======================================
+ Hits 998 999 +1
Misses 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@afc163 This fixes one of the most glaring a11y issues with react-component/table. Can you please merge it? |
|
@zombieJ Can you merge this please? |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria- attributes should be applied to the
<table>element. Instead, they are applied to the great grandparent of the<table>element where they serve no purpose. eg:This PR moves them to the correct element. As a result, screen readers will correctly announce the table.
This PR does NOT change where the data- props are added (still on the great grandparent of the
<table>element).ref: UIEN-973