-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support 'treeExpandAction' prop for TreeSelect #411
Feat: support 'treeExpandAction' prop for TreeSelect #411
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 468 468
Branches 127 135 +8
=========================================
Hits 468 468
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
a1da393
to
ed87245
Compare
少侠,再补个用例。测一下这个 treeExpandAction 传下去了 |
这个也要补 test 吗。。不知道怎么算测了, |
ed87245
to
1529743
Compare
@zombieJ 我苦思冥想试着加了一个,你看是这个意思不 |
最好是用 testing lib 的 fireEvent 点击测试,测试组件的 props 有点强依赖了。另外我看 文档 好像还没有写上这个新的属性哈 |
@zombieJ 另外不管是直接 还是上面的疑问
|
@zombieJ 二哥,求指导! |
嗯,就是重复 Tree 的测试。但是不一样的点是你知道 Tree expandAction 是有效的。但是你其实不知道 TreeSelect 里 treeExpandAction 是有效的。所以才需要配置完毕后,模拟点开下拉框。然后在下拉框上点击,测试是否展开。 两者区别在于 Tree 的点击能力是 TreeSelect 的子集。所以我们需要确认的是 TreeSelect 里也同样生效。而不能因为 Tree 测过了,封装一层的 TreeSelect 就不测了。把 Tree 当黑盒来区分。 |
1529743
to
34fcc80
Compare
34fcc80
to
2bc48a3
Compare
2bc48a3
to
243d54c
Compare
@zombieJ done,你看看阔以不 |
243d54c
to
3db6940
Compare
@zombieJ 都改啦,你看看阔以不 |
|
See ant-design/ant-design#35137 for more details.