fix: not remove touchstart listenr before unmount (#206)

* fix: not remove touchstart listenr before unmount * chore: move mode
react-component · Jul 12, 2023 · ec122a9 · ec122a9
1 parent 884060e
commit ec122a9
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/ScrollBar.tsx b/src/ScrollBar.tsx
@@ -58,6 +58,8 @@ export default class ScrollBar extends React.Component<ScrollBarProps, ScrollBar
 
   componentWillUnmount() {
     this.removeEvents();
+    this.scrollbarRef.current?.removeEventListener('touchstart', this.onScrollbarTouchStart);
+    this.thumbRef.current?.removeEventListener('touchstart', this.onMouseDown);
     clearTimeout(this.visibleTimeout);
   }
 
@@ -92,10 +94,7 @@ export default class ScrollBar extends React.Component<ScrollBarProps, ScrollBar
     window.removeEventListener('mousemove', this.onMouseMove);
     window.removeEventListener('mouseup', this.onMouseUp);
 
-    this.scrollbarRef.current?.removeEventListener('touchstart', this.onScrollbarTouchStart);
-
     if (this.thumbRef.current) {
-      this.thumbRef.current.removeEventListener('touchstart', this.onMouseDown);
       this.thumbRef.current.removeEventListener('touchmove', this.onMouseMove);
       this.thumbRef.current.removeEventListener('touchend', this.onMouseUp);
     }
@@ -122,7 +121,6 @@ export default class ScrollBar extends React.Component<ScrollBarProps, ScrollBar
   onMouseMove = (e: MouseEvent | TouchEvent) => {
     const { dragging, pageY, startTop } = this.state;
     const { onScroll } = this.props;
-
     raf.cancel(this.moveRaf);
 
     if (dragging) {