Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra offset position not cover #220

Merged
merged 3 commits into from
Aug 18, 2023
Merged

fix: extra offset position not cover #220

merged 3 commits into from
Aug 18, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 18, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtual-list ❌ Failed (Inspect) Aug 18, 2023 2:09am

@@ -104,17 +105,20 @@
boxSizing: 'border-box',
}}
extraRender={(info) => {
const { offsetX, rtl: isRTL } = info;
const { offsetX, offsetY, rtl: isRTL } = info;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable offsetX.
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #220 (d2b0d14) into master (fae5c99) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head d2b0d14 differs from pull request most recent head 734c108. Consider uploading reports for the commit 734c108 to get more accurate results

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   99.48%   99.48%   -0.01%     
==========================================
  Files          16       16              
  Lines         587      585       -2     
  Branches      121      121              
==========================================
- Hits          584      582       -2     
  Misses          3        3              
Files Changed Coverage Δ
src/Filler.tsx 100.00% <ø> (ø)
src/List.tsx 99.50% <100.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 6dd4fbf into master Aug 18, 2023
8 of 9 checks passed
@zombieJ zombieJ deleted the fix-extraOffset branch August 18, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant