Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-Start-Date-Style #1710

Closed
wants to merge 6 commits into from
Closed

Fix-Start-Date-Style #1710

wants to merge 6 commits into from

Conversation

mmarkelov
Copy link
Contributor

Will fix #1599, #1703

@coveralls
Copy link

coveralls commented Jun 26, 2019 •
edited

Coverage Status

Coverage remained the same at 85.095% when pulling e9d1e7e on mmarkelov:Fix-Start-Date-Style into 310205c on airbnb:master.

@lencioni lencioni requested review from majapw and nkinser June 26, 2019 15:40
@lencioni
Copy link
Contributor

@mmarkelov thanks for the PR! Any chance you could add a regression test to prevent this from being reintroduced?

@lencioni
Copy link
Contributor

Merged in 13ee107

@lencioni lencioni closed this Jun 26, 2019
This was referenced Jun 26, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lencioni lencioni lencioni approved these changes

@majapw majapw Awaiting requested review from majapw

@nkinser nkinser Awaiting requested review from nkinser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

startDate UI is broken if startDate time is not 12:00:00
3 participants
@mmarkelov @coveralls @lencioni