[New] Add 'fixed' option to allow position-fixed appendToBody pickers #2228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are trying to use the date-picker in a small
position: fixed
container withoverflow: hidden
. To make it escape its container using a portal, we useappendToBody={true}
This mostly works, but because the container is appended to the body in a static layout, the date picker becomes invisible once we scroll down the page.
Fix
appendToBody="fixed"
as an additional option, in addition to the normal booleans. Update all PropTypesTesting
Added new automated Mocha tests that verify that
position: 'fixed'
gets added whenappendToBody="fixed"
is set