Turn on 'jsx-a11y/label-has-for' rule

react-dnd · Jan 25, 2017 · d3ebb39 · d3ebb39
1 parent c11d1eb
commit d3ebb39
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/examples/.eslintrc b/examples/.eslintrc
@@ -4,7 +4,6 @@
         "import/no-extraneous-dependencies": "off",
         "import/no-unresolved": "off",
         "import/prefer-default-export": "off",
-        "jsx-a11y/label-has-for": "off",
         "max-len": "off",
         "no-param-reassign": "off",
         "object-curly-spacing": "off",

diff --git a/examples/02 Drag Around/Custom Drag Layer/index.js b/examples/02 Drag Around/Custom Drag Layer/index.js
@@ -45,15 +45,17 @@ export default class DragAroundCustomDragLayer extends Component {
         <Container snapToGrid={snapToGridAfterDrop} />
         <CustomDragLayer snapToGrid={snapToGridWhileDragging} />
         <p>
-          <label>
-            <input type='checkbox'
+          <label htmlFor='snapToGridWhileDragging'>
+            <input id='snapToGridWhileDragging'
+                   type='checkbox'
                    checked={snapToGridWhileDragging}
                    onChange={this.handleSnapToGridWhileDraggingChange} />
             <small>Snap to grid while dragging</small>
           </label>
           <br />
-          <label>
-            <input type='checkbox'
+          <label htmlFor='snapToGridAfterDrop'>
+            <input id='snapToGridAfterDrop'
+                   type='checkbox'
                    checked={snapToGridAfterDrop}
                    onChange={this.handleSnapToGridAfterDropChange} />
             <small>Snap to grid after drop</small>

diff --git a/examples/02 Drag Around/Naive/index.js b/examples/02 Drag Around/Naive/index.js
@@ -44,8 +44,9 @@ export default class DragAroundNaive extends Component {
         </p>
         <Container hideSourceOnDrag={hideSourceOnDrag} />
         <p>
-          <label>
-            <input type='checkbox'
+          <label htmlFor='hideSourceOnDrag'>
+            <input id='hideSourceOnDrag'
+                   type='checkbox'
                    checked={hideSourceOnDrag}
                    onChange={this.handleHideSourceClick} />
             <small>Hide the source item while dragging</small>