Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't drag down on iOS 13 #1585

Closed
fokayx opened this issue Oct 25, 2019 · 6 comments · Fixed by #1631
Closed

Can't drag down on iOS 13 #1585

fokayx opened this issue Oct 25, 2019 · 6 comments · Fixed by #1631

Comments

@fokayx
Copy link

fokayx commented Oct 25, 2019

Describe the bug
While iOS upgrade to 13, our dnd sortable list component can drag up but can't drag down. All it worked in iOS < 12. Is it a bug in iOS 13 ? Have any idea?

Desktop (please complete the following information):

  • OS: iOS
  • Browser: chrome, safari
  • Version 78.0.3904.67
@fsp
Copy link

fsp commented Oct 25, 2019

I've also observed this problem starting iOS 13.1 and it is still present in iOS 13.2 beta. I am using a custom drag layer with the touch backend.

This seems to be an issue with WebKit on iOS specifically.

@zhusee2
Copy link
Contributor

zhusee2 commented Oct 30, 2019

Also experiencing the same thing on iOS 13.2 release. It seems to be happening in the “sorting” context.

While you can drag a node anywhere trouble-free, if you re-render a list when you drag item A downward onto item B, you can suddenly loose control to the dragging node. But the drag isn't considered as end–the endDrag() callback is triggered only when your finger really leaves the screen.

It almost happen every time as you drag downward and and re-render. It can also happen when you drag upward, but that's a relatively rare case.

@zhusee2
Copy link
Contributor

zhusee2 commented Oct 31, 2019

I took a closer look at the touch backend, and I found it's stuck at TouchBackend.ts#L390 because it can't find event client offset.

Turned out that in iOS 13, event.targetTouches list from touchmove event can be cleared out in the above situation, even when the only Touch target in its event.touches is the same node from touchstart event.

@fsp
Copy link

fsp commented Oct 31, 2019

This may be related to this webkit issue

@varseb
Copy link

varseb commented Nov 12, 2019

Same issue here.
Still present on last IOS update to 13.2.2

@thenano
Copy link

thenano commented Dec 2, 2019

I'm also experiencing this and have confirmed that everything works as expected on iOS 12.
Thanks for providing a fix @zhusee2 !
Hopefully the fix can be merged soon. Thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants