Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct iframe rendering in Firefox #639

Closed
darthtrevino opened this issue Feb 3, 2017 · 2 comments
Closed

Correct iframe rendering in Firefox #639

darthtrevino opened this issue Feb 3, 2017 · 2 comments

Comments

@darthtrevino
Copy link
Member

The iframe content in the examples, using react-frame-component is not rendering in FF, probably due to an error in react-frame-component

@jmancherje
Copy link

It also doesn't seem to work on Chrome. When I ran the iframe example on Chrome I get these errors:

HTML5Backend.js?0327:300 Uncaught TypeError: Cannot read property 'unshift' of undefined
    at HTML5Backend.handleDragStart (eval at <anonymous> (main.js:8449), <anonymous>:300:28)
    at HTMLDivElement.handleDragStart (eval at <anonymous> (main.js:8449), <anonymous>:130:21)
handleDragStart @ HTML5Backend.js?0327:300
handleDragStart @ HTML5Backend.js?0327:130
HTML5Backend.js?0327:421 Uncaught TypeError: Cannot read property 'unshift' of undefined
    at HTML5Backend.handleDragEnter (eval at <anonymous> (main.js:8449), <anonymous>:421:28)
    at HTMLDivElement.handleDragEnter (eval at <anonymous> (main.js:8449), <anonymous>:154:21)
handleDragEnter @ HTML5Backend.js?0327:421
handleDragEnter @ HTML5Backend.js?0327:154
HTML5Backend.js?0327:462 Uncaught TypeError: Cannot read property 'unshift' of undefined
    at HTML5Backend.handleDragOver (eval at <anonymous> (main.js:8449), <anonymous>:462:27)
    at HTMLDivElement.handleDragOver (eval at <anonymous> (main.js:8449), <anonymous>:157:21)
handleDragOver @ HTML5Backend.js?0327:462
handleDragOver @ HTML5Backend.js?0327:157

@darthtrevino
Copy link
Member Author

You need to have the libs npm linked for iframes to work at the moment. I'll cut a minor version tonight

darthtrevino added a commit that referenced this issue Mar 6, 2017
react-frame-component had an error rendering within Firefox that has been corrected.
darthtrevino added a commit that referenced this issue Mar 6, 2017
react-frame-component had an error rendering within Firefox that has been corrected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants