Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Native File DnD example #687

Closed
wants to merge 6 commits into from
Closed

Add Native File DnD example #687

wants to merge 6 commits into from

Conversation

theTechie
Copy link
Member

I have added a native file dnd example

darthtrevino
darthtrevino requested changes Mar 10, 2017
View reviewed changes
Copy link
Member

@darthtrevino darthtrevino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment in the publish step. It looks good though. I'll run it this weekend to make sure it hangs together well in the docs site.

scripts/publishStaticSite.sh Outdated
@@ -3,7 +3,7 @@ set -e

PROJECT_DIRECTORY="react-dnd"
SITE_DIRECTORY="$PROJECT_DIRECTORY-site"
GITHUB_REPO="git@github.com:react-dnd/react-dnd.git"
GITHUB_REPO="git@github.com:thetechie/react-dnd.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably stay the same

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad. have reverted this.

@darthtrevino
Copy link
Member

Hey @theTechie ,
I just had a chance to play around with the examples on my end. The native file example looks great; my only concern is that the example itself is miscategorized in the left-nav. It's currently under 'Customize', which I think should be for UI customization.

I think we should make a new left-nav category called "Other Cases", and let's rename your example "Native Files", since DnD is implied here. I'll submit a PR to your fork in a minute here.

screen shot 2017-03-13 at 10 38 17 am

@darthtrevino darthtrevino mentioned this pull request Mar 13, 2017
Closed
darthtrevino added a commit that referenced this pull request Mar 14, 2017
@darthtrevino
Update #687 - Native File Example (#696)
9e062eb 
* add native file DnD example

* add native file DnD example

* fix lint errors

* revert repo url

* Update the native file example by adding an 'other' category
@theTechie
Copy link
Member Author

theTechie commented Mar 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darthtrevino darthtrevino darthtrevino requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theTechie @darthtrevino