Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental hook-based examples #1256

Merged
merged 16 commits into from
Mar 8, 2019
Merged

Conversation

darthtrevino
Copy link
Member

@darthtrevino darthtrevino commented Mar 8, 2019

To use the hook-based examples in the docsite for playing with, add the query argument ?experimental to the URL of any example.

Known issues:

  • Stress test example is slow
  • Simple sortable list desynchronizes with the dnd-core after dragging an item around a lot
  • The dragPreview image example uses a promise to load the image instead of a ref. The ref was causing the need to have a double-drag.
  • In experimental mode, clicking on the navigation for an example you're currently on will cause a double-backend error.

@darthtrevino darthtrevino merged commit e649b6a into master Mar 8, 2019
@darthtrevino darthtrevino deleted the feature/hooks_examples branch January 13, 2020 21:02
darthtrevino added a commit that referenced this pull request Feb 3, 2022
* refactor: rename the hook-example tags in the index

* docs: add a docsite queryarg to switch into experimental mode

This will allow us to test out the hooks-api without having to change what users normally see.

* docs: add headerto chessboard hooks example

* docs: move dustbin box to hooks

* docs: working on hook examples

* docs: get hooks examples compiling

* refactor: make the begin() function optional

* refactor: hooks api cleanup

* docs: add headers to hook-based examples

* fix: use drop return value in useDropTargetHandler

* docs: get dustbin examples working

* docs: update dragLayer example

* docs: fix custom drag layer example

* docs: get hooks working with more examples

* feat: allow the hooks dragPreview to be a promise

* fix: remove text fixtures from hooks examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant