Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate builds into ES-Modules #1383

Merged
merged 8 commits into from
Jun 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@
],
"moduleNameMapper": {
"^react-dnd$": "<rootDir>/packages/react-dnd/src",
"^react-dnd-decorators$": "<rootDir>/packages/react-dnd-decorators/src",
"^react-dnd-html5-backend$": "<rootDir>//packages/react-dnd-html5-backend/src",
"^react-dnd-test-backend$": "<rootDir>//packages/react-dnd-test-backend/src",
"^react-dnd-test-utils$": "<rootDir>//packages/react-dnd-test-utils/src",
Expand Down
11 changes: 5 additions & 6 deletions packages/dnd-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@
"version": "7.6.0",
"description": "Drag and drop sans the GUI",
"license": "MIT",
"main": "./lib/esm/index.js",
"module": "./lib/esm/index.js",
"types": "./lib/esm/index.d.ts",
"main": "./lib/index.js",
"module": "./lib/index.js",
"types": "./lib/index.d.ts",
"scripts": {
"build:esm": "tsc -b tsconfig.esm.json",
"build": "run-p build:*",
"build": "tsc -b tsconfig.json",
"clean": "rimraf lib",
"start": "tsc -b tsconfig.esm.json -w --preserveWatchOutput",
"start": "tsc -b tsconfig.json -w --preserveWatchOutput",
"test": "run-s clean build"
},
"repository": {
Expand Down
5 changes: 2 additions & 3 deletions packages/dnd-core/src/DragDropMonitorImpl.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
declare var require: any

import { Store } from 'redux'
import matchesType from './utils/matchesType'
import {
Expand All @@ -16,7 +14,8 @@ import {
HandlerRegistry,
Identifier,
} from './interfaces'
const invariant = require('invariant')
// @ts-ignore
import invariant from 'invariant'

export default class DragDropMonitorImpl implements DragDropMonitor {
constructor(private store: Store<State>, public registry: HandlerRegistry) {}
Expand Down
8 changes: 4 additions & 4 deletions packages/dnd-core/src/HandlerRegistryImpl.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
declare var require: any

import { Store } from 'redux'
import {
addSource,
Expand All @@ -23,8 +21,10 @@ import {
validateTargetContract,
validateType,
} from './contracts'
const invariant = require('invariant')
const asap = require('asap')
// @ts-ignore
import invariant from 'invariant'
// @ts-ignore
import asap from 'asap'

function getNextHandlerId(role: HandlerRole): string {
const id = getNextUniqueId().toString()
Expand Down
5 changes: 2 additions & 3 deletions packages/dnd-core/src/actions/dragDrop/beginDrag.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
declare var require: any

import {
Action,
DragDropManager,
Expand All @@ -11,7 +9,8 @@ import {
} from '../../interfaces'
import { setClientOffset } from './local/setClientOffset'
import { isObject } from '../../utils/discount_lodash'
const invariant = require('invariant')
// @ts-ignore
import invariant from 'invariant'

import { BEGIN_DRAG, INIT_COORDS } from './types'

Expand Down
4 changes: 2 additions & 2 deletions packages/dnd-core/src/actions/dragDrop/drop.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import {
} from '../../interfaces'
import { DROP } from './types'
import { isObject } from '../../utils/discount_lodash'
declare var require: any
const invariant = require('invariant')
// @ts-ignore
import invariant from 'invariant'

export default function createDrop<Context>(manager: DragDropManager<Context>) {
return function drop(options = {}): void {
Expand Down
6 changes: 2 additions & 4 deletions packages/dnd-core/src/actions/dragDrop/endDrag.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
declare var require: any

import {
DragDropManager,
SentinelAction,
DragDropMonitor,
} from '../../interfaces'
import { END_DRAG } from './types'

const invariant = require('invariant')
// @ts-ignore
import invariant from 'invariant'

export default function createEndDrag<Context>(
manager: DragDropManager<Context>,
Expand Down
6 changes: 2 additions & 4 deletions packages/dnd-core/src/actions/dragDrop/hover.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
declare var require: any

import {
Action,
DragDropManager,
Expand All @@ -10,8 +8,8 @@ import {
} from '../../interfaces'
import matchesType from '../../utils/matchesType'
import { HOVER } from './types'

const invariant = require('invariant')
// @ts-ignore
import invariant from 'invariant'

export default function createHover<Context>(
manager: DragDropManager<Context>,
Expand Down
5 changes: 2 additions & 3 deletions packages/dnd-core/src/contracts.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
declare var require: any

import { DragSource, DropTarget, Identifier } from './interfaces'
const invariant = require('invariant')
// @ts-ignore
import invariant from 'invariant'

export function validateSourceContract(source: DragSource) {
invariant(
Expand Down
8 changes: 0 additions & 8 deletions packages/dnd-core/tsconfig.cjs.json

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": "../../tsconfig.cjs.base.json",
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"outDir": "./lib/cjs",
"outDir": "lib",
"baseUrl": "./src"
},
"include": ["src/index.ts"]
Expand Down
4 changes: 2 additions & 2 deletions packages/documentation/src/components/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as React from 'react'
import Helmet from 'react-helmet'
import styled from 'styled-components'
import HTML5Backend from 'react-dnd-html5-backend'
import { isDebugMode } from 'react-dnd-examples-hooks/lib/esm/index'
import { isDebugMode } from 'react-dnd-examples-hooks/lib/index'
import { DndProvider } from 'react-dnd'
import PageBody from './pagebody'
import Sidebar from './sidebar'
Expand All @@ -13,7 +13,7 @@ import { APIPages, ExamplePages } from '../constants'
import Header from './header'
import './layout.css'
import { isLegacyMode } from '../util/renderHtmlAst'
require('prismjs/themes/prism.css')
import 'prismjs/themes/prism.css'
const favicon = require('../favicon.png')

export interface LayoutProps {
Expand Down
12 changes: 7 additions & 5 deletions packages/documentation/src/util/renderHtmlAst.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
declare var require: any
import { createElement } from 'react'
import { componentIndex as decoratorComponentIndex } from 'react-dnd-examples-decorators/lib/esm/index'
import { componentIndex as hookComponentIndex } from 'react-dnd-examples-hooks/lib/esm/index'
import { componentIndex as decoratorComponentIndex } from 'react-dnd-examples-decorators/lib/index'
import { componentIndex as hookComponentIndex } from 'react-dnd-examples-hooks/lib/index'
import { parse } from 'query-string'
import processImages from './processImagesInMarkdownAst'
import exampleTabs from '../components/exampleTabs'
const log = require('debug')('site:renderHtmlAst')
const rehypeReact = require('rehype-react')
import debug from 'debug'
// @ts-ignore
import rehypeReact from 'rehype-react'

const log = debug('site:renderHtmlAst')

export function isLegacyMode() {
if (typeof window !== 'undefined') {
Expand Down
3 changes: 2 additions & 1 deletion packages/documentation/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{
"extends": "../../tsconfig.esm.base.json",
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"outDir": "./lib",
"baseUrl": "./",
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"declaration": false,
"allowJs": true
},
"include": ["./src/index.ts"]
Expand Down
9 changes: 4 additions & 5 deletions packages/examples-decorators/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,20 @@
"version": "7.6.0",
"private": true,
"description": "Drag and Drop for React",
"main": "lib/cjs/index.js",
"types": "lib/cjs/index.d.ts",
"main": "lib/index.js",
"types": "lib/index.d.ts",
"repository": {
"type": "git",
"url": "https://github.com/react-dnd/react-dnd.git"
},
"license": "MIT",
"scripts": {
"clean": "rimraf lib",
"build:cjs": "tsc -b tsconfig.cjs.json",
"build:esm": "tsc -b tsconfig.esm.json",
"build:ts": "tsc -b tsconfig.json",
"build:docs": "tsc -b tsconfig.docs.json",
"build": "run-p build:*",
"test": "run-s clean build",
"start": "tsc -b tsconfig.cjs.json -w --preserveWatchOutput"
"start": "tsc -b tsconfig.json -w --preserveWatchOutput"
},
"dependencies": {
"@types/faker": "^4.1.5",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React from 'react'
import { ConnectDropTarget, DropTargetMonitor } from 'react-dnd'
import { DropTarget } from 'react-dnd-decorators'

const style: React.CSSProperties = {
height: '12rem',
width: '12rem',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from 'react-dnd-test-utils'
import { mount } from 'enzyme'
import { TestBackend } from 'react-dnd-test-backend'
import { DndComponent as DndC } from 'react-dnd'
import { DndComponent as DndC } from 'react-dnd-decorators'

describe('Dustbin: Multiple Targets', () => {
it('behaves as expected', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
declare var require: any

import React from 'react'
import { DndProvider } from 'react-dnd'
import HTML5Backend from 'react-dnd-html5-backend'
import Dustbin from './Dustbin'
import Box from './Box'

const {
default: Frame,
FrameContextConsumer,
} = require('react-frame-component')
// @ts-ignore
import Frame, { FrameContextConsumer } from 'react-frame-component'

const FrameBindingContext: React.FC = ({ children }) => (
<FrameContextConsumer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Box from '../Box'
import { wrapInTestContext } from 'react-dnd-test-utils'
import { mount } from 'enzyme'
import { TestBackend } from 'react-dnd-test-backend'
import { ContextComponent } from 'react-dnd'
import { ContextComponent } from 'react-dnd-decorators'

describe('Box', () => {
// TODO: test utils are acting wonking with function components.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from 'react-dnd-test-utils'
import { mount } from 'enzyme'
import { TestBackend } from 'react-dnd-test-backend'
import { DndComponent } from 'react-dnd'
import { DndComponent } from 'react-dnd-decorators'

describe('Integration: Dustbin Single Target', () => {
it('can simulate a full drag and drop interaction', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
declare var require: any
import React, { useState, useEffect, useCallback } from 'react'
import { NativeTypes } from 'react-dnd-html5-backend'
import Dustbin from './Dustbin'
import Box from './Box'
import ItemTypes from './ItemTypes'
import update from 'immutability-helper'
const shuffle = require('lodash/shuffle')
// @ts-ignore
import shuffle from 'lodash/shuffle'

export interface SourceBox {
name: string
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
declare var require: any
import React from 'react'
import { ConnectDropTarget, DropTargetMonitor } from 'react-dnd'
import { DropTarget, DropTargetConnector } from 'react-dnd-decorators'
import ItemTypes from './ItemTypes'
import DraggableBox from './DraggableBox'
import snapToGrid from './snapToGrid'
const update = require('immutability-helper')
// @ts-ignore
import update from 'immutability-helper'

const styles: React.CSSProperties = {
width: 300,
Expand Down
10 changes: 0 additions & 10 deletions packages/examples-decorators/tsconfig.cjs.json

This file was deleted.

2 changes: 1 addition & 1 deletion packages/examples-decorators/tsconfig.docs.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "./tsconfig.esm.json",
"extends": "./tsconfig.json",
"compilerOptions": {
"allowSyntheticDefaultImports": true,
"jsx": "preserve",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"extends": "../../tsconfig.esm.base.json",
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"allowSyntheticDefaultImports": true,
"outDir": "./lib/esm",
"outDir": "./lib",
"baseUrl": "./"
},
"include": ["./src/index.ts"]
Expand Down
9 changes: 4 additions & 5 deletions packages/examples-hooks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,20 @@
"version": "7.6.0",
"private": true,
"description": "Drag and Drop for React",
"main": "lib/cjs/index.js",
"types": "lib/cjs/index.d.ts",
"main": "lib/index.js",
"types": "lib/index.d.ts",
"repository": {
"type": "git",
"url": "https://github.com/react-dnd/react-dnd.git"
},
"license": "MIT",
"scripts": {
"clean": "rimraf lib",
"build:cjs": "tsc -b tsconfig.cjs.json",
"build:esm": "tsc -b tsconfig.esm.json",
"build:ts": "tsc -b tsconfig.json",
"build:docs": "tsc -b tsconfig.docs.json",
"build": "run-p build:*",
"test": "run-s clean build",
"start": "tsc -b tsconfig.cjs.json -w --preserveWatchOutput"
"start": "tsc -b tsconfig.json -w --preserveWatchOutput"
},
"dependencies": {
"@types/faker": "^4.1.5",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
declare var require: any

import React from 'react'
import { DndProvider } from 'react-dnd'
import HTML5Backend from 'react-dnd-html5-backend'
import Dustbin from './Dustbin'
import Box from './Box'

const {
default: Frame,
FrameContextConsumer,
} = require('react-frame-component')
// @ts-ignore
import Frame, { FrameContextConsumer } from 'react-frame-component'

const FrameBindingContext: React.FC = ({ children }) => (
<FrameContextConsumer>
Expand Down
4 changes: 2 additions & 2 deletions packages/examples-hooks/src/01-dustbin/stress-test/index.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
declare var require: any
import React, { useState, useEffect, useCallback } from 'react'
import { NativeTypes } from 'react-dnd-html5-backend'
import Dustbin from './Dustbin'
import Box from './Box'
import ItemTypes from './ItemTypes'
import update from 'immutability-helper'
const shuffle = require('lodash/shuffle')
// @ts-ignore
import shuffle from 'lodash/shuffle'

export interface SourceBox {
name: string
Expand Down