Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't handle dragstart event if default is prevented #1426

Merged
merged 2 commits into from Jul 3, 2019
Merged

fix: don't handle dragstart event if default is prevented #1426

merged 2 commits into from Jul 3, 2019

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Jun 24, 2019

If someone has invoked preventDefault on the dragstart event, dragend would never come, so it's probably better we just do nothing.

@darthtrevino darthtrevino merged commit 3a70c80 into react-dnd:master Jul 3, 2019
@upsuper upsuper deleted the default-prevented branch July 3, 2019 20:28
darthtrevino pushed a commit that referenced this pull request Feb 3, 2022
@upsuper @darthtrevino
fix: don't handle dragstart event if default is prevented (#1426)
6ebd18b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darthtrevino darthtrevino darthtrevino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@upsuper @darthtrevino