Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert a recent PR that made the draggable attribute conditional #3379

Merged
merged 4 commits into from
Feb 6, 2022

Conversation

darthtrevino
Copy link
Member

@darthtrevino darthtrevino commented Feb 6, 2022

Fixes #3378

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #3379 (6aff3d8) into main (89aa31d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 6aff3d8 differs from pull request most recent head 895d611. Consider uploading reports for the commit 895d611 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3379   +/-   ##
=======================================
  Coverage   56.75%   56.75%           
=======================================
  Files         196      196           
  Lines        3110     3110           
  Branches      555      555           
=======================================
  Hits         1765     1765           
  Misses       1345     1345           
Impacted Files Coverage Δ
packages/backend-html5/src/HTML5BackendImpl.ts 13.91% <0.00%> (ø)

@darthtrevino darthtrevino merged commit fa20dc8 into main Feb 6, 2022
@darthtrevino darthtrevino deleted the fix/drag_drop_liveness branch February 6, 2022 16:36
@dmbarry86
Copy link

Is this included in 15.1.2 release? I don't see any mention of it in release notes but notice it has been merged so just wanted to check.

@darthtrevino
Copy link
Member Author

Yup, it was in 15.1.1

@dmbarry86
Copy link

dmbarry86 commented Feb 8, 2022

Yup, it was in 15.1.1

Thanks. Incidentally I don't see a 15.1.1 release. Just seems to jump from 15.1.0 to 15.1.2. Anyway thanks for the fix.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't drag multiple times in 15.x release
2 participants