Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript error with Control #3002

Closed
rusefendi opened this issue Sep 25, 2020 · 1 comment · Fixed by #3005
Closed

Typescript error with Control #3002

rusefendi opened this issue Sep 25, 2020 · 1 comment · Fixed by #3005
Labels
bug Something isn't working TS Typescript related issues

Comments

@rusefendi
Copy link

Describe the bug
Typescript error with Control type from example (https://react-hook-form.com/ts#Control)

To Reproduce

  1. Open https://codesandbox.io/s/objective-raman-jyt0g?file=/src/App.tsx
  2. Look at the control prop from IsolateReRender component.
  3. See error

Codesandbox link (Required)
https://codesandbox.io/s/objective-raman-jyt0g?file=/src/App.tsx

Expected behavior
Not having any errors
@bluebill1049 bluebill1049 added bug Something isn't working TS Typescript related issues labels Sep 25, 2020
@bluebill1049
Copy link
Member

bluebill1049 commented Sep 25, 2020 •
edited

This issue is occurred at 6.8.5

possible related to this PR: #2899

This was referenced Sep 26, 2020
Closed
Merged
bluebill1049 added a commit that referenced this issue Sep 26, 2020
@bluebill1049
🐞 fix #3002 with Control type throw error (#3005)
357916b 
* Revert "⌨️ refactor UseFormMethods to arrow functions (#2899)"

This reverts commit 3d713b3.

* attach useWatch type test

* include Control generic

* fix some minor type error

* fix readme
@bluebill1049 bluebill1049 mentioned this issue Sep 26, 2020
Closed
Tymek added a commit to Tymek/react-hook-form that referenced this issue Oct 13, 2020
@Tymek
add test case for Control type
cabb589 
vs. Typescript error with Control react-hook-form#3002
Tymek added a commit to Tymek/react-hook-form that referenced this issue Oct 13, 2020
@Tymek
add test case for Control type
63b99c8 
vs. Typescript error with Control react-hook-form#3002
@Tymek Tymek mentioned this issue Oct 13, 2020
Closed
@amankkg amankkg mentioned this issue Nov 22, 2020
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working TS Typescript related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3002 react-hook-form/react-hook-form
2 participants
@rusefendi @bluebill1049