⌨️ refactor UseFormMethods to arrow functions #2899

Tymek · 2020-09-14T05:43:26Z

resolves #2887

fix react-hook-form#2887 thanks to https://stackoverflow.com/a/50757806/1729641

codesandbox-ci · 2020-09-15T06:41:10Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6da53e6:

Sandbox	Source
react-hook-form/react-hook-form: app	Configuration

Tymek · 2020-09-15T06:44:29Z

I got the main issue down, but I don't understand why TypeScript complains about generics in multiple invocation signatures while it was fine using overloaded functions :|

bluebill1049 · 2020-09-15T07:50:30Z

Thanks @Tymek I will take a look at it.

src/useForm.ts

bluebill1049 · 2020-09-15T09:57:59Z

actually @kotarella1110 did you had a similar issue before? I remember from one of the PR. it was to do with the type order. is this a result of cycle reference with Control?

kotarella1110 · 2020-09-15T15:24:55Z

@bluebill1049 yes. I had a similar problem before (please see #1412 (comment)).
The solution was to change the order of the methods in the Control type.
The cause of this is not well understood...
I tested this and this passes... strange...

bluebill1049 · 2020-09-15T22:54:24Z

Thanks @kotarella1110 i will play with it a bit more.

bluebill1049 · 2020-09-17T03:54:29Z

I am having issue to get this one over the line as well, attached with help wanted tag, hopefully someone can figure out the reason and i will take a look at it again as well.

bluebill1049 · 2020-09-17T10:43:53Z

It's a super crap this one, as unit tests pass locally.

bluebill1049 · 2020-09-17T11:28:16Z

my 🧠 is fried... @kotarella1110 if you some free time, please help to take a look at this...

Tymek · 2020-09-19T08:05:26Z

I did some more debugging and.. this is madness

maybe we can create matching Control from name, instead of trying to infer it?
what this type check does, is checking if right name exists on Control
inverting this will check if we can use passed Control with this name

Tymek · 2020-09-19T18:21:39Z

I have no idea why tests passed locally, but I had the same problem. I sidestepped it with docker run -it -v ${PWD}:/srv -w /srv circleci/node:lts bash instead of loosing my sanity asking what are the differences between yarn test and npm test 😆

bluebill1049 · 2020-09-20T01:06:01Z

@Tymek I got my 🧠 fried by this issue... I couldn't find a clue why tests failed everyone and then, while e2e constantly(build) failed. I am not even sure it's our code or ts...

JeromeDeLeon · 2020-09-20T03:49:30Z

This is the only time we could probably say that It works on my local. I have tried them out myself but no luck.

…ethod

bluebill1049 · 2020-09-23T05:53:25Z

Thanks for trying to solve this "hard" problem @Tymek 🙏 ❤️

Tymek · 2020-09-23T06:03:50Z

Your're welcome 😉 I'm glad that I can help

CI tests finally passed 🎉

bluebill1049 · 2020-09-23T06:10:40Z

oh wow! thank you! the power of OSS.

bluebill1049 · 2020-09-23T06:11:19Z

src/controller.tsx

@@ -7,8 +7,7 @@ import skipValidation from './logic/skipValidation';
 import isNameInFieldArray from './logic/isNameInFieldArray';
 import { useFormContext } from './useFormContext';
 import { VALUE } from './constants';
-import { Control } from './types';
-import { ControllerProps } from './types';
+import { ControllerProps, FieldValues } from './types';


bluebill1049 · 2020-09-23T06:12:52Z

src/controller.tsx

-}: ControllerProps<TAs, TControl>) => {
-  const methods = useFormContext();
+}: ControllerProps<TAs, TFieldValues>) => {
+  const methods = useFormContext<TFieldValues>();


in theory changing this might break someone's build, but it's a niche case

kotarella1110

wow! amazing 🏆
looks so good! 💯
Thank you very much!!!!!

bluebill1049 · 2020-09-23T23:05:05Z

Thank you very much @Tymek 🎖️ and @kotarella1110 for the review. 🙏

https://twitter.com/HookForm/status/1308908370284490753

This reverts commit 3d713b3.

bluebill1049 · 2020-09-26T01:39:59Z

Looks like this PR caused some issues... I am temporally rever it back 🙏

* Revert "⌨️ refactor UseFormMethods to arrow functions (#2899)" This reverts commit 3d713b3. * attach useWatch type test * include Control generic * fix some minor type error * fix readme

⌨️ refactor UseFormMethods to arrow functions

238fe02

fix react-hook-form#2887 thanks to https://stackoverflow.com/a/50757806/1729641

Tymek marked this pull request as draft September 14, 2020 05:46

⌨️🐞 fix FormContext type

e6ec747

Tymek force-pushed the ts-eslint-unbound-method branch from 1af6feb to 6974f3e Compare September 15, 2020 06:37

⌨️🐞 fix inconsistent type of setValue in useForm

1ec110a

Tymek force-pushed the ts-eslint-unbound-method branch from 6974f3e to 1ec110a Compare September 15, 2020 06:42

Merge branch 'master' into ts-eslint-unbound-method

01299bb

bluebill1049 marked this pull request as ready for review September 15, 2020 07:50

bluebill1049 requested a review from kotarella1110 September 15, 2020 07:51

bluebill1049 reviewed Sep 15, 2020

View reviewed changes

src/useForm.ts Outdated Show resolved Hide resolved

bluebill1049 added 3 commits September 15, 2020 19:28

Update src/useForm.ts

5209278

fix setValue at controller

8fcdc5e

fix setValue type

e78d2d5

bluebill1049 added the help wanted Extra attention is needed label Sep 17, 2020

bluebill1049 added 4 commits September 17, 2020 20:33

Merge branch 'master' into ts-eslint-unbound-method

5b8fdec

change type to interface

872d842

try to fix the issue by kotara's feedback

f20e77c

atemp 2

23fb085

bluebill1049 added 4 commits September 17, 2020 20:51

try to align with useForm methods with types

efc78e5

fix getValues()

53f7147

remove extra types

57132a5

update methods order

b4b4853

Merge branch 'master' into ts-eslint-unbound-method

217a940

🐞 fix control type

eae8716

Tymek requested a review from bluebill1049 September 20, 2020 16:18

Tymek added 2 commits September 22, 2020 19:53

Merge remote-tracking branch 'source/master' into ts-eslint-unbound-m…

6d1aec6

…ethod

restore control validateResolver type

134218c

Update README.md

c204393

bluebill1049 reviewed Sep 23, 2020

View reviewed changes

kotarella1110 approved these changes Sep 23, 2020

View reviewed changes

Merge branch 'master' into ts-eslint-unbound-method

6da53e6

bluebill1049 merged commit 3d713b3 into react-hook-form:master Sep 23, 2020

bluebill1049 mentioned this pull request Sep 25, 2020

Typescript error with Control #3002

Closed

bluebill1049 added a commit that referenced this pull request Sep 26, 2020

Revert "⌨️ refactor UseFormMethods to arrow functions (#2899)"

ed1ea84

This reverts commit 3d713b3.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⌨️ refactor UseFormMethods to arrow functions #2899

⌨️ refactor UseFormMethods to arrow functions #2899

Tymek commented Sep 14, 2020

codesandbox-ci bot commented Sep 15, 2020 •

edited

Loading

Tymek commented Sep 15, 2020

bluebill1049 commented Sep 15, 2020

bluebill1049 commented Sep 15, 2020 •

edited

Loading

kotarella1110 commented Sep 15, 2020 •

edited

Loading

bluebill1049 commented Sep 15, 2020

bluebill1049 commented Sep 17, 2020

bluebill1049 commented Sep 17, 2020 •

edited

Loading

bluebill1049 commented Sep 17, 2020

Tymek commented Sep 19, 2020

Tymek commented Sep 19, 2020 •

edited

Loading

bluebill1049 commented Sep 20, 2020

JeromeDeLeon commented Sep 20, 2020

bluebill1049 commented Sep 23, 2020

Tymek commented Sep 23, 2020

bluebill1049 commented Sep 23, 2020

bluebill1049 Sep 23, 2020

bluebill1049 Sep 23, 2020

Tymek Sep 23, 2020

kotarella1110 left a comment

bluebill1049 commented Sep 23, 2020 •

edited

Loading

bluebill1049 commented Sep 26, 2020

⌨️ refactor UseFormMethods to arrow functions #2899

⌨️ refactor UseFormMethods to arrow functions #2899

Conversation

Tymek commented Sep 14, 2020

codesandbox-ci bot commented Sep 15, 2020 • edited Loading

Tymek commented Sep 15, 2020

bluebill1049 commented Sep 15, 2020

bluebill1049 commented Sep 15, 2020 • edited Loading

kotarella1110 commented Sep 15, 2020 • edited Loading

bluebill1049 commented Sep 15, 2020

bluebill1049 commented Sep 17, 2020

bluebill1049 commented Sep 17, 2020 • edited Loading

bluebill1049 commented Sep 17, 2020

Tymek commented Sep 19, 2020

Tymek commented Sep 19, 2020 • edited Loading

bluebill1049 commented Sep 20, 2020

JeromeDeLeon commented Sep 20, 2020

bluebill1049 commented Sep 23, 2020

Tymek commented Sep 23, 2020

bluebill1049 commented Sep 23, 2020

bluebill1049 Sep 23, 2020

Choose a reason for hiding this comment

bluebill1049 Sep 23, 2020

Choose a reason for hiding this comment

Tymek Sep 23, 2020

Choose a reason for hiding this comment

kotarella1110 left a comment

Choose a reason for hiding this comment

bluebill1049 commented Sep 23, 2020 • edited Loading

bluebill1049 commented Sep 26, 2020

codesandbox-ci bot commented Sep 15, 2020 •

edited

Loading

bluebill1049 commented Sep 15, 2020 •

edited

Loading

kotarella1110 commented Sep 15, 2020 •

edited

Loading

bluebill1049 commented Sep 17, 2020 •

edited

Loading

Tymek commented Sep 19, 2020 •

edited

Loading

bluebill1049 commented Sep 23, 2020 •

edited

Loading