Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👔 Improve Form component onSubmit and remove fetcher #10425

Merged
merged 6 commits into from
May 20, 2023

Conversation

bluebill1049
Copy link
Member

@bluebill1049 bluebill1049 commented May 20, 2023

  • remove fetcher prop
  • rename values to data
  • update onSubmit callback with FormData and FormDataJSON
<Form 
-  fetcher={() => {}}
+  onSubmit={({ data, formData, formDataJSON }) => {
+    console.log(data)
+ }}
/>

@codesandbox
Copy link

codesandbox bot commented May 20, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2023

Size Change: -31 B (0%)

Total Size: 19.8 kB

Filename Size Change
dist/index.cjs.js 9.83 kB -16 B (0%)
dist/index.umd.js 9.92 kB -15 B (0%)

compressed-size-action

@bluebill1049 bluebill1049 changed the title remove fetcher prop and leverage action prop 👔 Improve Form component onSubmit and remove fetcher May 20, 2023
@bluebill1049 bluebill1049 marked this pull request as ready for review May 20, 2023 04:43
@bluebill1049 bluebill1049 merged commit c6ba96c into master May 20, 2023
6 checks passed
@Moshyfawn Moshyfawn deleted the form-action branch June 1, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant