Revert breaking type change in #10342 #10609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
The change really messed up our app too. Should have been a major version change. |
bluebill1049
approved these changes
Jun 28, 2023
|
We will introduce this in the following major release then. |
|
When (re)releasing this PR, I would strongly suggest to shortly document how to take advantage of the improved type checking by showing the needed changes for some typical use cases. |
1 task
|
Hi, |
|
A release next week would be 👨🍳 💋 |
will do. |
|
Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the type changes introduced in #10342.
The type changes are positive, but releasing it in a minor release have led to large issues for many consumers. I suggest reverting the changes for now and introducing them in the next major release.
See the discussion in #10342 for more details.