Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isDirty when setting disabled in register #10805

Merged
merged 3 commits into from Aug 18, 2023
Merged

Update isDirty when setting disabled in register #10805

merged 3 commits into from Aug 18, 2023

Conversation

selimb
Copy link
Contributor

@selimb selimb commented Aug 18, 2023

Fixes #10804

@codesandbox
Copy link

codesandbox bot commented Aug 18, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@selimb selimb marked this pull request as ready for review August 18, 2023 13:44
@selimb selimb changed the title [draft] Update isDirty when setting disabled in register Update isDirty when setting disabled in register Aug 18, 2023
bluebill1049
bluebill1049 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the patch.

@bluebill1049 bluebill1049 merged commit 75ae6e7 into react-hook-form:master Aug 18, 2023
7 checks passed
This was referenced Oct 17, 2023
Closed
Closed
@fzaninotto fzaninotto mentioned this pull request Oct 24, 2023
Merged
@fzaninotto fzaninotto mentioned this pull request Jan 12, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluebill1049 bluebill1049 bluebill1049 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issue: isDirty is not updated after toggling disabled in register()
2 participants
@selimb @bluebill1049