🙄 close #10932 omit disabled prop when not defined

[bluebill1049]

fix #10932

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[github-actions]

Size Change: +27 B (0%)

Total Size: 19.9 kB

Filename	Size	Change
dist/index.cjs.js	9.92 kB	+15 B (0%)
dist/index.umd.js	10 kB	+12 B (0%)

_{compressed-size-action}

[Pumpuli]

With the addition of the "disable whole form" feature, it's now technically possible to receive { disabled: undefined } again.

The change makes this situation possible:

const { control } = useForm({ disabled: false });

return <Controller
  // No `disabled` prop given here
  control={control}
  render={({ field }) => {
    // `field.disabled` is `undefined`
  }}
/>;

Maybe this is not critical, since it can only happen when field.disabled is supposed to be false (in other words, that undefined is never going to override anything that's supposed to be truthy).

An easy fix would be to use nullish coalescing operator here:

react-hook-form/src/useController.ts

Line 130 in 0d565fc

? { disabled: formState.disabled || disabled }

[bluebill1049]

With the addition of the "disable whole form" feature, it's now technically possible to receive { disabled: undefined } again.

The change makes this situation possible:

const { control } = useForm({ disabled: false });

return <Controller
  // No `disabled` prop given here
  control={control}
  render={({ field }) => {
    // `field.disabled` is `undefined`
  }}
/>;

Maybe this is not critical, since it can only happen when field.disabled is supposed to be false (in other words, that undefined is never going to override anything that's supposed to be truthy).

An easy fix would be to use nullish coalescing operator here:

react-hook-form/src/useController.ts

Line 130 in 0d565fc

? { disabled: formState.disabled || disabled }

Feel free to send a PR.