Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 #11106 fix disabled prop not update dirty formState #11143

Merged
merged 3 commits into from
Nov 5, 2023
Merged

🐞 #11106 fix disabled prop not update dirty formState #11143

merged 3 commits into from
Nov 5, 2023

Conversation

bluebill1049
Copy link
Member

@bluebill1049 bluebill1049 commented Nov 5, 2023 •
edited

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Nov 5, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023 •
edited

Size Change: +57 B (0%)

Total Size: 20.2 kB

Filename Size Change
dist/index.cjs.js 10.1 kB +29 B (0%)
dist/index.umd.js 10.1 kB +28 B (0%)

compressed-size-action

@bluebill1049 bluebill1049 merged commit 30e5c42 into master Nov 5, 2023
6 of 7 checks passed
@bluebill1049 bluebill1049 deleted the fix-disabled-input-dirty-state branch November 5, 2023 05:42
@villesau
Copy link

villesau commented Jan 6, 2024 •
edited

This breaks isDirty check for us. It resets back to true even with: reset({}, { keepValues: true, keepDirty: false });

This issue should probably be reopened as there's bunch of people confused about htis: #11192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bluebill1049 @villesau