Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ValidationModeFlags Type #11144

Merged
merged 2 commits into from Nov 5, 2023

Conversation

ssi02014
Copy link
Contributor

@ssi02014 ssi02014 commented Nov 5, 2023

@bluebill1049 👋
I added ValidationModeFlags and reused them to improve the type.

Copy link

codesandbox bot commented Nov 5, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@ssi02014
Copy link
Contributor Author

ssi02014 commented Nov 5, 2023

I'm getting an error building ci/codesandbox
It seems to be related to the pnpm, node version.
I feel like there's nothing I can do. 😂

From https://github.com/react-hook-form/react-hook-form
 * [new ref]           refs/pull/11144/head -> origin/pull/11144
+ git checkout -qf remotes/origin/pull/11144 (in /tmp/586c01e3)
+ node -v (in /tmp/586c01e3)
v14.21.1
+ pnpm -v (in /tmp/586c01e3)
ERROR: This version of pnpm requires at least Node.js v16.14
The current version of Node.js is v14.21.1
Visit https://r.pnpm.io/comp to see the list of past pnpm versions with respective Node.js version support.
Error: Process rejected with status code 1
    at ChildProcess.<anonymous> (/app/dist/utils/exec.js:20:27)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess._handle.onexit (node:internal/child_process:292:12) {
  code: 1
}

스크린샷 2023-11-05 오후 3 54 19

@ssi02014 ssi02014 changed the title feat: Add ValidationModeFlags feat: Add ValidationModeFlags Type Nov 5, 2023
@ssi02014 ssi02014 changed the title feat: Add ValidationModeFlags Type feat: add ValidationModeFlags Type Nov 5, 2023
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluebill1049 bluebill1049 merged commit cf71480 into react-hook-form:master Nov 5, 2023
6 of 7 checks passed
@ssi02014 ssi02014 deleted the refac/type branch November 5, 2023 10:13
@ssi02014
Copy link
Contributor Author

ssi02014 commented Nov 5, 2023

@bluebill1049 Thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants