fix(#11239): Set fields disabled state based on form and field disabl… #11241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd field disabled prop
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
src/logic/createFormControl.ts
Outdated
| (ref, name) => { | ||
| const currentField = get(_fields, name); | ||
| if (currentField) { | ||
| ref.disabled = currentField._f.disabled || disabled; |
There was a problem hiding this comment.
probably need to check currentField._f.disabled is defined as well.
There was a problem hiding this comment.
Had a hard time figuring out if there is a standard way you like to check these, hope this is sufficient :)
Added a test as well.
bluebill1049
approved these changes
Nov 29, 2023
rafaelcalhau
pushed a commit
to rafaelcalhau/react-hook-form
that referenced
this pull request
May 5, 2024
… and field disabled (react-hook-form#11241) * fix(react-hook-form#11239): Set fields disabled state based on form and field disabled prop * fix(react-hook-form#11239): If-check and unit test * Update createFormControl.ts --------- Co-authored-by: Thomas De Bock <thomas.de.bock@persgroep.net> Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickfix on #11239
Needs some love by somebody who knows the internals better than I do.