🐛 fix(useController): check if disabled state was set by user #11353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Size Change: -1 B (0%) Total Size: 20.4 kB
ℹ️ View Unchanged
|
bluebill1049
approved these changes
Jan 2, 2024
rafaelcalhau
pushed a commit
to rafaelcalhau/react-hook-form
that referenced
this pull request
May 5, 2024
…hook-form#11353) * 🐛 fix(useController): check if disabled state was set by user Closes: react-hook-form#11320 * ✅ test(useController): disabled state is not overriden if not set Related: react-hook-form#11320 * 🎨 style(useController): format whitespaces * 🐛 fix(useController): set disabled state if passed to controller * ✅ test(useController): should respect disabled state on controller * 🎨 style: run prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isBooleanutility may not be suitable for checking if thedisabledstate is set, as it is primarily used for type-guards.