Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(formState, disabled): infer controlled disabled form state #11361

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Moshyfawn
Copy link
Member

@Moshyfawn Moshyfawn commented Jan 4, 2024

Since the disabled state of the form can be controlled, we should inherit the disabled state passed from the useForm hook. This will prevent the form from flashing the wrong state when it is disabled.

@Moshyfawn Moshyfawn linked an issue Jan 4, 2024 that may be closed by this pull request
1 task
Copy link

codesandbox bot commented Jan 4, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Size Change: +15 B (0%)

Total Size: 20.3 kB

Filename Size Change
dist/index.cjs.js 10.1 kB +8 B (0%)
dist/index.umd.js 10.2 kB +7 B (0%)

compressed-size-action

@bluebill1049
Copy link
Member

Thank you for the fix! <3

@bluebill1049 bluebill1049 merged commit e6a5b1a into master Jan 4, 2024
7 checks passed
@bluebill1049 bluebill1049 deleted the fix/controlled-disabled-form-state branch January 4, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue: Initial form context state does not match initial useForm props
2 participants