fix: change DeepPartial to account for object union types & unknown
#11385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
bluebill1049
approved these changes
Jan 13, 2024
|
This PR breaks types in global All data become optional |
I think the issue you're mentioning is related to #11359 🤔 |
rafaelcalhau
pushed a commit
to rafaelcalhau/react-hook-form
that referenced
this pull request
May 5, 2024
…nown` (react-hook-form#11385) * feat: extract objects from DeepPartial check * chore: api-extractor * fix: api-extractor build --------- Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the previous enhancement to allow
unknownto be compatible withDeepPartial(#11333), it introduced an unintended bug, being incompatible with union types containing both object & non-object types. Although this was resolved in #11373, it again made the definition ofDeepPartialincompatible with any types containingunknownagain.With a new proposed definition that should be able to handle such cases, I have added some test cases discovered throughout #11333 and #11373 as type tests along with the new definition. By using
ExtractObjectsto extract any type that extendsobjectfrom a potential union type, it successfully appliesDeepPartialfor such object types while supportingunknownas well.