Extend union type of form methods for new Form component #11764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, when using the new form component with Nextjs server actions, a warning is outputted in the browser console.
```
const methods = useForm<SearchFormValues>({
defaultValues: {
// default values
},
progressive: true,action
});
const [formState, action] = useFormState(namOfAction(), null);
<Form
action={action}
control={methods.control}
method="post"
>
//
</Form>
```
```
Warning: Prop `method` did not match. Server: "POST" Client: "post"
```
Changing "post" to "POST" removes the warning in the browser console, but triggers a TypeScript warning as the method props only contains 'post' | 'put' | 'delete'; This change adds "POST" to the union type.
Cheers
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, when using the experimental
Formcomponent with Nextjs server actions, the following warning is outputted in the browser console:Example
Changing
"post"to"POST"removes the warning in the browser console, but triggers a TypeScript warning as the method type only contains'post' | 'put' | 'delete'This change adds uppercase variants of the existing methods to the union type.Cheers