Cast checkbox value to string explicitly #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c298213:
|
bluebill1049
reviewed
Aug 9, 2020
src/useForm.ts
Outdated
| (checkboxRef.checked = (value as string).includes( | ||
| checkboxRef.value, | ||
| )), | ||
| (checkboxRef.checked = (value as string | boolean) |
There was a problem hiding this comment.
String(value) is perhaps shorter? (see if can save few bytes)
|
Thanks @Toleckk for the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rare error 'value.includes is not a function', that appears on controlled form with checkboxes array resetting, if fields order was changed.
Steps to reproduce the behavior:
Expected behavior
Value of checkbox should change after click