✨ Add support for generic components using `FieldPathWithValue` #6562

julienfouilhe · 2021-09-16T00:39:47Z

This seems like a better and much simpler API for the support of generic components than #6466

If the expected type is not specified to useController/Controller, then all possible types from the FieldValues are returned.

You can look at the test in useController.test.tsx for how it can be used.

julienfouilhe · 2021-09-16T01:05:15Z

cc @bluebill1049 @kotarella1110 and @barrymay since you were tagged as reviewers on my other PR.

~~I could not find a way to keep the tests the same, I had to explicitly pass the types to userController/Controller. I think there may be a way to infer everything.~~

Edit: Nvm, found a way! :)

This reverts commit 2058b5b.

src/useController.ts

src/types/controller.ts

bluebill1049

LGTM.

bluebill1049 · 2021-09-16T02:30:08Z

let's wait for @barrymay and @kotarella1110's review feedback 🙏

kotarella1110

Amazing!!! 🙌
Please check my comments.

src/types/controller.ts

julienfouilhe · 2021-09-28T20:09:32Z

@bluebill1049 Done! Sorry for the force-push which dismissed @kotarella1110 review! I usually rebase instead of merge so I was confused for a moment. But all good now!

The diff of the merge commit is weird but I just moved a type I had called ControllerFieldErrors and that was below ControllerFieldState above it, and renamed it ControllerFieldError which was the name used in one of the latest commits on master.

I also added expectations in my tests as @barrymay suggested. Since they were tests that just ensured everything was typed correctly, I just put basic expectations.

bluebill1049 · 2021-09-28T23:54:02Z

Thanks for everyone's contribution and review. Let's do another patch release for all the bug fixes before release this as a new minor update. I will merge that once the patch goes out, there are still few small issues yet to be resolved.

bluebill1049 · 2021-09-30T01:28:30Z

Just some thoughts, if this is a pattern that we all agree on, perhaps we can introduce something similar to useFieldArray? any thoughts.

julienfouilhe · 2021-09-30T07:30:15Z

@bluebill1049 Definitely something that can be applied to it too!
I don't know how people create generic components. I mainly use Controller thus why I implemented it there, but if others use extensively useFieldArray (which I haven't used much for now) it could be useful to make that change there later too!

bluebill1049 · 2021-10-05T07:03:58Z

src/types/controller.ts

-  DeepPartialImpl<UnionLike<T>>,
-  FieldError
->;
+type ControllerFieldError<


I didn't pay close enough attention here, @kotarella1110 this was completely changed after the merge.

which potentially lead to this: #6679

@bluebill1049 I don't understand the linked issue is talking about versions before this was merged right?

i am just digging around at the moment, see if i can find a fix for it.

DeepMapImpl<DeepPartialImpl<UnionLike<TFieldValues>>, FieldError>

vs

DeepMap<DeepPartial<UnionLike<TFieldValues>>, FieldError>

still try to get my head around it.

ok confirmed the latest definitely related for causing the issue, it could be related to the user's typescript version as well, as i couldn't reproduce the issue at the lib level but codesandbox with CRA, after omit TResult and the issue went away.

https://codesandbox.io/s/pedantic-elbakyan-s04xv?file=/src/App.tsx

bluebill1049 · 2021-10-05T09:12:26Z

I have to revert this one back guys, i don't have quick solution yet and it probably impact a lot of users.

…e` (#6562)" This reverts commit f5a2519.

bluebill1049 · 2021-10-05T09:19:48Z

we can come back to this, I am sorry to roll this back but it's better not impact more users.

…e` (#6562)" (#6717) This reverts commit f5a2519.

bluebill1049 · 2021-10-05T09:52:37Z

I think we still want this awesome feature.

reproduce the issue locally (the one in codesadnbox) https://codesandbox.io/s/pedantic-elbakyan-s04xv?file=/src/App.tsx switch to 17.0.0, it's strange behavior as it wasn't having the issue within all the test local lib has...
re-open the PR and publish again

barrymay · 2021-10-05T13:15:36Z

switch to 17.0.0

For clarity, switch RHF to 7.17.0 to see the issue. As you said, very strange this didn't come up in the test run. I agree this feature is very much worth trying to get right (and also worth ensuring our test runs can catch this too)

slbls · 2021-10-07T20:30:25Z

I'm new to contributing but would love to help out with this. What can I do to get started on making this viable again?

bluebill1049 · 2021-10-07T22:02:16Z

thanks @slbls once this one is unblocked, we are pretty confident to bring this feature back.

exneval · 2021-10-08T12:59:49Z

hope this can be reimplemented

bluebill1049 · 2021-10-08T13:05:20Z

@julienfouilhe can you push and open this PR again? I think we can get this one back now.

…WithValue` (#6562)" (#6717)" This reverts commit 08883bb.

bluebill1049 · 2021-10-09T00:08:59Z

let's run that in the next tag for a while, let us know how did you guys go.

react-hook-form@7.18.0-next.0

https://github.com/react-hook-form/react-hook-form/releases/tag/v7.18.0-next.0

going to play more cautious with any TS-related update.

barrymay · 2021-10-09T04:22:10Z

See my note here about this issue: #6753 (comment)

…#6753) * Revert "Revert "✨ Add support for generic components using `FieldPathWithValue` (#6562)" (#6717)" This reverts commit 08883bb. * keep FieldError simple * fix with error object with only FieldError type * 7.18.0-next.0 * include test case for controller with type check

✨ Add support for generic components using FieldPathWithValue

3674c13

julienfouilhe mentioned this pull request Sep 16, 2021

Make Path carry the expected result type to allow fully typed generic components #6466

Closed

✅ Fix tests

2058b5b

julienfouilhe added 3 commits September 16, 2021 03:23

✨ Fix inference

0ec5243

Revert "✅ Fix tests"

cae4e5a

This reverts commit 2058b5b.

🎨 Improve readibility of FieldPathWithValue

1fdf829

bluebill1049 requested review from kotarella1110 and barrymay September 16, 2021 01:43

julienfouilhe commented Sep 16, 2021

View reviewed changes

src/useController.ts Show resolved Hide resolved

julienfouilhe commented Sep 16, 2021

View reviewed changes

src/types/controller.ts Outdated Show resolved Hide resolved

bluebill1049 previously approved these changes Sep 16, 2021

View reviewed changes

barrymay previously approved these changes Sep 16, 2021

View reviewed changes

Merge branch 'master' into generic-components

c71740c

kotarella1110 reviewed Sep 16, 2021

View reviewed changes

src/types/controller.ts Outdated Show resolved Hide resolved

src/types/controller.ts Show resolved Hide resolved

kotarella1110 reviewed Sep 16, 2021

View reviewed changes

src/types/controller.ts Outdated Show resolved Hide resolved

✨ Use TResult for ControllerFieldState too

e2710df

julienfouilhe dismissed stale reviews from barrymay and bluebill1049 via e2710df September 16, 2021 16:17

julienfouilhe and others added 6 commits September 16, 2021 18:49

✨ Put UnpackNestedValue back

c5508fe

Merge branch 'master' into generic-components

f3cf1ee

Merge branch 'master' into generic-components

35c50f5

Merge branch 'master' into generic-components

d98f28a

Merge branch 'master' into generic-components

67d1361

✅ Add test for generic components with NestedValue

3995e2f

julienfouilhe requested review from bluebill1049, kotarella1110 and barrymay September 22, 2021 01:23

Merge branch 'master' into generic-components

d959d59

✅ Add expectations

cbc07d9

Merge branch 'master' into generic-components

e7396f1

bluebill1049 approved these changes Sep 28, 2021

View reviewed changes

barrymay approved these changes Sep 29, 2021

View reviewed changes

Merge branch 'master' into generic-components

1339ab4

Merge branch 'master' into generic-components

4e7c435

Merge branch 'master' into generic-components

40d5fd3

bluebill1049 merged commit f5a2519 into react-hook-form:master Oct 2, 2021

bluebill1049 reviewed Oct 5, 2021

View reviewed changes

bluebill1049 added a commit that referenced this pull request Oct 5, 2021

Revert "✨ Add support for generic components using `FieldPathWithValu…

430d561

…e` (#6562)" This reverts commit f5a2519.

bluebill1049 mentioned this pull request Oct 5, 2021

Revert "✨ Add support for generic components using `FieldPathWithVal… #6717

Merged

bluebill1049 added a commit that referenced this pull request Oct 5, 2021

Revert "✨ Add support for generic components using `FieldPathWithValu…

08883bb

…e` (#6562)" (#6717) This reverts commit f5a2519.

bluebill1049 added a commit that referenced this pull request Oct 8, 2021

Revert "Revert "✨ Add support for generic components using `FieldPath…

65e1836

…WithValue` (#6562)" (#6717)" This reverts commit 08883bb.

bluebill1049 mentioned this pull request Oct 8, 2021

Revert "Revert "✨ Add support for generic components using `FieldPat… #6753

Merged

mrnerdhair mentioned this pull request Nov 24, 2021

chore: upgrade typescript to 4.5.2 shapeshift/web#477

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add support for generic components using `FieldPathWithValue` #6562

✨ Add support for generic components using `FieldPathWithValue` #6562

julienfouilhe commented Sep 16, 2021 •

edited

julienfouilhe commented Sep 16, 2021 •

edited

bluebill1049 left a comment

bluebill1049 commented Sep 16, 2021

kotarella1110 left a comment

julienfouilhe commented Sep 28, 2021 •

edited

bluebill1049 commented Sep 28, 2021

bluebill1049 commented Sep 30, 2021

julienfouilhe commented Sep 30, 2021

bluebill1049 Oct 5, 2021

bluebill1049 Oct 5, 2021

julienfouilhe Oct 5, 2021

bluebill1049 Oct 5, 2021

bluebill1049 Oct 5, 2021

bluebill1049 Oct 5, 2021

bluebill1049 Oct 5, 2021 •

edited

bluebill1049 Oct 5, 2021

bluebill1049 commented Oct 5, 2021

bluebill1049 commented Oct 5, 2021

bluebill1049 commented Oct 5, 2021

barrymay commented Oct 5, 2021

slbls commented Oct 7, 2021

bluebill1049 commented Oct 7, 2021 •

edited

exneval commented Oct 8, 2021 •

edited

bluebill1049 commented Oct 8, 2021

bluebill1049 commented Oct 9, 2021 •

edited

barrymay commented Oct 9, 2021

✨ Add support for generic components using FieldPathWithValue #6562

✨ Add support for generic components using FieldPathWithValue #6562

Conversation

julienfouilhe commented Sep 16, 2021 • edited

julienfouilhe commented Sep 16, 2021 • edited

bluebill1049 left a comment

Choose a reason for hiding this comment

bluebill1049 commented Sep 16, 2021

kotarella1110 left a comment

Choose a reason for hiding this comment

julienfouilhe commented Sep 28, 2021 • edited

bluebill1049 commented Sep 28, 2021

bluebill1049 commented Sep 30, 2021

julienfouilhe commented Sep 30, 2021

bluebill1049 Oct 5, 2021

Choose a reason for hiding this comment

bluebill1049 Oct 5, 2021

Choose a reason for hiding this comment

julienfouilhe Oct 5, 2021

Choose a reason for hiding this comment

bluebill1049 Oct 5, 2021

Choose a reason for hiding this comment

bluebill1049 Oct 5, 2021

Choose a reason for hiding this comment

bluebill1049 Oct 5, 2021

Choose a reason for hiding this comment

bluebill1049 Oct 5, 2021 • edited

Choose a reason for hiding this comment

bluebill1049 Oct 5, 2021

Choose a reason for hiding this comment

bluebill1049 commented Oct 5, 2021

bluebill1049 commented Oct 5, 2021

bluebill1049 commented Oct 5, 2021

barrymay commented Oct 5, 2021

slbls commented Oct 7, 2021

bluebill1049 commented Oct 7, 2021 • edited

exneval commented Oct 8, 2021 • edited

bluebill1049 commented Oct 8, 2021

bluebill1049 commented Oct 9, 2021 • edited

barrymay commented Oct 9, 2021

✨ Add support for generic components using `FieldPathWithValue` #6562

✨ Add support for generic components using `FieldPathWithValue` #6562

julienfouilhe commented Sep 16, 2021 •

edited

julienfouilhe commented Sep 16, 2021 •

edited

julienfouilhe commented Sep 28, 2021 •

edited

bluebill1049 Oct 5, 2021 •

edited

bluebill1049 commented Oct 7, 2021 •

edited

exneval commented Oct 8, 2021 •

edited

bluebill1049 commented Oct 9, 2021 •

edited