Migrate from Select.options to Select.selectedOptions #6678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move from `options` to `selectedOptions` to reduce code and safe one array traversal. See https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedOptions for more information. Will not work in IE11!
Since we moved from `Select.options` to `Select.selectedOptions` we don't need to filter for selected options by ourselfs anymore.
|
looks like build failed, i will take a look at it today after work 👍 |
bluebill1049
added a commit
that referenced
this pull request
Oct 1, 2021
* Migrate from Select.options to Select.selectedOptions (#6678) * Add selectedOptions as a performance improvement Move from `options` to `selectedOptions` to reduce code and safe one array traversal. See https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedOptions for more information. Will not work in IE11! * Remove unnecessary .filter for selected options Since we moved from `Select.options` to `Select.selectedOptions` we don't need to filter for selected options by ourselfs anymore. Co-authored-by: Bill <bluebill1049@hotmail.com> * fix type error * update tests * remove .only Co-authored-by: Kai Dorschner <krnlde@users.noreply.github.com>
Yes sorry, I didn't have time to setup the whole environment :D |
|
haha all good buddy, thanks for the contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a tiny performance boost and reduces code, since we safe an unnecessary
Array.filter.