Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Select.options to Select.selectedOptions #6678

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Migrate from Select.options to Select.selectedOptions #6678

merged 3 commits into from
Oct 1, 2021

Commits on Sep 30, 2021

  1. Add selectedOptions as a performance improvement 

    Move from `options` to `selectedOptions` to reduce code and safe one array traversal.

See https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedOptions for more information.

Will not work in IE11!
    @krnlde
    krnlde committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    3fe36d0 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary .filter for selected options 

    Since we moved from `Select.options` to `Select.selectedOptions` we don't need to filter for selected options by ourselfs anymore.
    @krnlde
    krnlde committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    b1a8f4f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Merge branch 'feature/selectOptions' into master

    @bluebill1049
    bluebill1049 committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    0d8d226 View commit details
    Browse the repository at this point in the history