New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Airtable RSVP #79
Conversation
- RSPV data will be recorded in Airtable - Name, Github Username is requested from the site - Airtable plugin is used to query for attendee data for display. Currently this is just the total number, until we implement a toggle for people to hide their profiles from display. - Signing up is done through a Netlify function which inserts the data into Airtable. - As of this commit, local development will require an Airtable API key.
src/templates/Meetup/index.jsx
Outdated
<section> | ||
<h2><span role="img" aria-label="busts in silhouette">👥</span> Attendees <span role="img" aria-label="busts in silhouetee">👥</span></h2> | ||
<p>{allAirtable.totalCount} attendees</p> | ||
{/* @TODO: Put this back when we have added the ability for people to hide their profile */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now we can still display this but put a caption to ask people to put down "react-knowledgeable" in their GitHub handle if they do not want to display their attendance. This way we still get the RSVP but we show our own avatar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, before we implement the Github OAuth, people can just leave the username field empty. Then we won't know it and hence won't show their avatar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I am slightly leaning towards having GitHub OAuth for sign in land together with this PR then.
|
|
Yah good point, can. |
Updates:
Regarding this
I feel making it apparently optional would make it much less likely for people to put down their GH handle, which we rely on to get avatars. We can still interpret empty input as In the long run let's still try to replace this with GitHub auth. |
LGTM, let's cut this draft 🕹 |
Cleaned this up a bit
Note that although Netlify functions exist in different environments (like deploy previews), we only have one airtable.. table. So we should think about how to not anyhow insert into there (like when you are doing local development)