Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Airtable RSVP #79

Merged
merged 10 commits into from Nov 17, 2019
Merged

Feature: Airtable RSVP #79

merged 10 commits into from Nov 17, 2019

Conversation

thchia
Copy link
Member

@thchia thchia commented Nov 9, 2019

Cleaned this up a bit

  • RSPV data will be recorded in Airtable
    • Name, Github Username is requested from the site
  • Airtable plugin is used to query for attendee data for display. Currently this is just the total number, until we implement a toggle for people to hide their profiles from display.
  • Signing up is done through a Netlify function which inserts the data into Airtable.
  • As of this commit, local development will require an Airtable API key.

Note that although Netlify functions exist in different environments (like deploy previews), we only have one airtable.. table. So we should think about how to not anyhow insert into there (like when you are doing local development)

- RSPV data will be recorded in Airtable
  - Name, Github Username is requested from the site
- Airtable plugin is used to query for attendee data for display. Currently this is just the total number, until we implement a toggle for people to hide their profiles from display.
- Signing up is done through a Netlify function which inserts the data into Airtable.
- As of this commit, local development will require an Airtable API key.
@thchia thchia requested a review from wgao19 November 9, 2019 02:18
gatsby-node.js Show resolved Hide resolved
src/functions/airtable.js Outdated Show resolved Hide resolved
<section>
<h2><span role="img" aria-label="busts in silhouette">👥</span> Attendees <span role="img" aria-label="busts in silhouetee">👥</span></h2>
<p>{allAirtable.totalCount} attendees</p>
{/* @TODO: Put this back when we have added the ability for people to hide their profile */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now we can still display this but put a caption to ask people to put down "react-knowledgeable" in their GitHub handle if they do not want to display their attendance. This way we still get the RSVP but we show our own avatar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, before we implement the Github OAuth, people can just leave the username field empty. Then we won't know it and hence won't show their avatar.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I am slightly leaning towards having GitHub OAuth for sign in land together with this PR then.

@wgao19
Copy link
Member

wgao19 commented Nov 9, 2019

  • for the option to hide attendance, let's simplify down to displaying our own avatar (the handle is react-knowledgeable) when people don't want to display their own, then we can display the list of avatars
  • let's use that one airtable table for development for now, in case we need more for testing in the future, we create a new table for testing, or we mock at netlify functions, depending on what we iterate on

@thchia
Copy link
Member Author

thchia commented Nov 9, 2019

  • Instead of asking them to put react-knowledgeable as the username, we can interpret empty username as that. So for empty usernames we show the RK avatar?
  • Agreed, probably mock in the function code.

@wgao19
Copy link
Member

wgao19 commented Nov 9, 2019

Instead of asking them to put react-knowledgeable as the username, we can interpret empty username as that. So for empty usernames we show the RK avatar?

Yah good point, can.

@wgao19
Copy link
Member

wgao19 commented Nov 16, 2019

Updates:

Regarding this

Instead of asking them to put react-knowledgeable as the username, we can interpret empty username as that. So for empty usernames we show the RK avatar?

I feel making it apparently optional would make it much less likely for people to put down their GH handle, which we rely on to get avatars. We can still interpret empty input as react-knowledgeable, but we tell people to put it down anyway just for the behavior.

In the long run let's still try to replace this with GitHub auth.

@thchia
Copy link
Member Author

thchia commented Nov 17, 2019

LGTM, let's cut this draft 🕹

@thchia thchia merged commit 0051559 into master Nov 17, 2019
@thchia thchia deleted the feature/airtable branch November 17, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants