Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove buildToolsVersion #615

Merged
merged 1 commit into from
May 31, 2021
Merged

remove buildToolsVersion #615

merged 1 commit into from
May 31, 2021

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented May 28, 2021

Summary

Setting buildToolsVersion is no longer recommended, it'll default to Android Gradle Plugin defaults. It makes DX worse by requiring multiple versions of build tools by various dependencies require various versions.

Test Plan

No visible changes, everything will work as before.

remove buildToolsVersion
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks 🙏

@krizzu krizzu merged commit 32f697a into react-native-async-storage:master May 31, 2021
@krizzu
Copy link
Member

krizzu commented May 31, 2021

🎉 This PR is included in version 1.15.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants