Fix for run-android on windows. (#2236)

* Fix for `run-android` on windows. * Comment added explaining why awaiting is not used --------- Co-authored-by: Abdullah Al Jahid <jahid@chaldal.net>
react-native-community · Dec 27, 2023 · a36eefc · a36eefc
1 parent 933f6cf
commit a36eefc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/packages/cli-platform-android/src/commands/runAndroid/index.ts b/packages/cli-platform-android/src/commands/runAndroid/index.ts
@@ -61,7 +61,8 @@ async function runAndroid(_argv: Array<string>, config: Config, args: Flags) {
     );
 
     if (startPackager) {
-      await startServerInNewWindow(
+      // Awaiting this causes the CLI to hang indefinitely, so this must execute without await.
+      startServerInNewWindow(
         newPort,
         config.root,
         config.reactNativePath,

diff --git a/packages/cli-tools/src/getDefaultUserTerminal.ts b/packages/cli-tools/src/getDefaultUserTerminal.ts
@@ -11,6 +11,10 @@ const getDefaultUserTerminal = (): string | undefined => {
     return TERM_PROGRAM;
   }
 
+  if (os.platform() === 'win32') {
+    return 'cmd.exe';
+  }
+
   return TERM;
 };
 

diff --git a/packages/cli-tools/src/startServerInNewWindow.ts b/packages/cli-tools/src/startServerInNewWindow.ts
@@ -103,7 +103,7 @@ function startServerInNewWindow(
   }
   if (isWindows) {
     // Awaiting this causes the CLI to hang indefinitely, so this must execute without await.
-    return execa('cmd.exe', ['/C', launchPackagerScript], {
+    return execa(terminal, ['/C', launchPackagerScript], {
       ...procConfig,
       detached: true,
       stdio: 'ignore',