Fix for run-android on windows.
#2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajahid
requested review from
cortinico,
adamTrz and
thymikee
as code owners
| @@ -61,7 +61,7 @@ async function runAndroid(_argv: Array<string>, config: Config, args: Flags) { | |||
| ); | |||
|
|
|||
| if (startPackager) { | |||
| await startServerInNewWindow( | |||
| startServerInNewWindow( | |||
There was a problem hiding this comment.
mind also adding comment why awaiting this function breaks things?
|
Is this related to facebook/react-native#42074 ? |
|
Let's backport this to 0.73 cc @thymikee |
thymikee
pushed a commit
that referenced
this pull request
Dec 27, 2023
* Fix for `run-android` on windows. * Comment added explaining why awaiting is not used --------- Co-authored-by: Abdullah Al Jahid <jahid@chaldal.net>
|
and we need a cli release first to fix on rn side? |
Yes, that's how it works. |
@szymonrybczak was this related to the linked issue? If so, can we make sure we pick it in a release? |
Yes, we'll handle this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2219
Fixes
run-androidcommand on windows.The issue is reported here - #2219
Bug was introduced on #2021
Issue is - there is no default terminal defined for windows. In the above mentioned PR - terminal param became mandatory. So it was failing.
It also fixes where it tries to run
startServerInNewWindowwith async call, which causes CLI to hang indefinitely. And the native build never starts.Test Plan:
24.12.2023_18.49.28_REC.mp4
Checklist