fix: Podfile.lock paths are no longer absolute #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
|
Once running |
thymikee
approved these changes
Jun 17, 2020
alloy
requested changes
Jun 18, 2020
|
Thanks, @alloy, I've added a simple test suite. Let me know if that works. Unfortunately, it turned out to be rather complex change and I had to perform some changes to the logic of the testing script itself. Not really proud of them, but I don't think there was a better way. Let me know if you have any other suggestions or this is good to go. |
thymikee
reviewed
Jun 19, 2020
packages/platform-ios/src/config/__tests__/native_modules.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Small regression introduced by a previous change to the file.
reactNativePathis absolute (as returned by the CLI configuration) in order to be used in various places.The path used by
Podfilehas to be relative to its location, hence the change. I am leaving the object as a return value to avoid changing RN files and make it easy to customize in the future.Context: The output of running
use_native_modulesis used here: https://github.com/facebook/react-native/tree/master/template/ios/Podfile#L9