doctor : Modifying the version ranges to keep up to date with RN 0.72 #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please fix failing tests? 🙏🏼 |
cortinico
approved these changes
Mar 6, 2023
szymonrybczak
pushed a commit
that referenced
this pull request
Mar 17, 2023
…#1858) * Modifying the version to keep up to date * Modifying the version to keep up to date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
React Native is increasing the minimum Android_SDK requirement from
Android SDK Platform 31toAndroid SDK Platform 33for 0.72 onwards.https://reactnative.dev/docs/next/environment-setup#installing-dependencies
ANDROID_SDKfrom versionRanges file is not used anymore. For theANDROID_SDKhealth check we're getting required SDK version fromandroid/build.gradlefile viagetBuildToolsVersionhelper function. So it depends what is shipped with core but updating the versionRanges for posterity. Similarly for theANDROID_NDKhttps://github.com/facebook/react-native/blob/574653319a1208ee21993da9e2576fc2eb7bf9e9/template/android/build.gradle#L5
Resolves #1855 & #1856
Test Plan:
No visible change, keeping the versionRanges for
ANDROID_SDK&ANDROID_NDKup-to-date in order to avoid confusion in future.