Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly check Yarn version #2412

Merged
merged 3 commits into from
Jun 24, 2024
Merged

fix: correctly check Yarn version #2412

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94dbab7
fix: correctly check Yarn version
szymonrybczak Jun 18, 2024
764e6b4
fix: apply reviewers comment
szymonrybczak Jun 19, 2024
951b816
Update packages/cli/src/commands/init/init.ts
szymonrybczak Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/cli/src/commands/init/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,10 @@ const bumpYarnVersion = async (silent: boolean, root: string) => {

if (yarnVersion) {
// `yarn set` is unsupported until 1.22, however it's a alias (yarnpkg/yarn/pull/7862) calling `policies set-version`.
const setVersionArgs =
yarnVersion.major > 1 && yarnVersion.minor >= 22
? ['set', 'version', YARN_VERSION]
: ['policies', 'set-version', YARN_VERSION];

let setVersionArgs = ['set', 'version', YARN_VERSION];
if (yarnVersion.major === 1 && yarnVersion.minor < 22) {
setVersionArgs = ['policies', 'set-version', YARN_VERSION];
}
await executeCommand('yarn', setVersionArgs, {
root,
silent,
Expand Down