Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launching chrome dev tools #63

Merged
merged 1 commit into from Jan 8, 2019

Conversation

@janicduplessis
Copy link
Contributor

commented Jan 8, 2019

We didn't pass the port to the middleware manager which is needed by the getDevToolsMiddleware to launch chrome dev tools.

@grabbou
grabbou approved these changes Jan 8, 2019

@grabbou grabbou merged commit 6de63fe into react-native-community:master Jan 8, 2019

3 checks passed

ci/circleci: install-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint-and-flow Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
@grabbou

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

Awesome @janicduplessis, thank you for this PR! Just in time for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.