Collapse YellowBox/DevTools frames in Metro config #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React Native master (note: commit not pushed to GitHub yet) is no longer stripping `YellowBox` and React DevTools stack frames from warnings with the `framesToPop` mechanism, which we will be deprecating and ultimately removing from the default error reporter too. The recommended approach going forward is to rely on Metro's `customizeFrame` for all postprocessing of stack traces. This commit updates the default Metro config to skip stack frames in `YellowBox` and React DevTools code, thus preserving the old behaviour. As for compatibility and versioning: It is harmless to run this change against older RN versions, but the next RN release should include this CLI change. (cc @cpojer)
thymikee
approved these changes
Oct 10, 2019
|
Mind fixing the linter? Looks like the regex could be simplified |
|
Whoops, the regex actually needs an extra backslash to correctly escape the |
|
The linter is happy now. Doesn't look like the e2e test failure is relevant. |
|
Thank you! |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 22, 2019
Summary: Removes support for the non-standard `framesToPop` error property from React Native. Redboxes will now ignore this field. The way to skip uninformative frames in stack traces going forward is to use Metro's `customizeFrame` config option, for which the React Native CLI ships useful defaults (see: react-native-community/cli#596, react-native-community/cli#780) Changelog: [General] [Removed] - Remove support for framesToPop from ExceptionsManager Reviewed By: rickhanlonii Differential Revision: D17877444 fbshipit-source-id: 04aa332c45ad35a99ae20e05fb87b34c91a557ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
React Native master (facebook/react-native@cf4d45e) is no longer stripping
YellowBoxand React DevTools stack frames from warnings with theframesToPopmechanism, which we will be deprecating and ultimately removing from the default error reporter too. The recommended approach going forward is to rely on Metro'scustomizeFramefor all postprocessing of stack traces.This commit updates the default Metro config to skip stack frames in
YellowBoxand React DevTools code, thus preserving the old user-visible behaviour. As for compatibility and versioning: It is harmless to run this change against older RN versions, but the next RN release should include this CLI change. (cc @cpojer)Test Plan:
We've made an identical change to our internal Metro config.