Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove locale prop #540

Merged
merged 1 commit into from Dec 11, 2021
Merged

feat: remove locale prop #540

merged 1 commit into from Dec 11, 2021

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Dec 11, 2021 •
edited

Summary

The module allowed overriding locale on ios, but doing so does not really work in newer ios versions. Supporting locales in your app should be done the "proper way" as seen here https://developer.apple.com/documentation/xcode/adding-support-for-languages-and-regions

this is also documented in readme

closes #522, #82, #233, #272, #282, #300, #330, #388, #429, #439, #274

Please open a new issue if you believe the prop should not be removed (explain why).

Test Plan

tested locally

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak merged commit 6637c03 into master Dec 11, 2021
@vonovak vonovak deleted the feat/remove-locale-prop branch December 11, 2021 14:20
vonovak pushed a commit that referenced this pull request Dec 11, 2021
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
7893787 
# [5.0.0](v4.0.1...v5.0.0) (2021-12-11)

### Features

* remove locale prop ([#540](#540)) ([6637c03](6637c03))

### BREAKING CHANGES

* locale prop removed
@vonovak
Copy link
Member Author

vonovak commented Dec 11, 2021

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Dec 11, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@vlad-ps vlad-ps mentioned this pull request Dec 13, 2021
Closed
vonovak added a commit that referenced this pull request Dec 20, 2021
@vonovak
Revert "feat: remove locale prop (#540)"
ce8faf4 
This reverts commit 6637c03.
vonovak added a commit that referenced this pull request Dec 20, 2021
@vonovak
feat: add back locale prop (#544)
05f39fa 
* Revert "feat: remove locale prop (#540)"

This reverts commit 6637c03.

* chore: update docs and minor changes

* fix screenshot?

* improve docs and screenshot
vonovak pushed a commit that referenced this pull request Dec 21, 2021
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
fc0c064 
# [5.1.0](v5.0.2...v5.1.0) (2021-12-21)

### Features

* add back locale prop ([#544](#544)) ([05f39fa](05f39fa)), closes [#540](#540)
@GabinH GabinH mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vonovak